From: Jean Delvare <jdelvare@suse.de>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Jarkko Nikula <jarkko.nikula@linux.intel.com>
Cc: Bjorn Helgaas <helgaas@kernel.org>,
Keijo Vaara <ferdasyn@rocketmail.com>,
"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-pm@vger.kernel.org, linux-pci@vger.kernel.org,
lkml <linux-kernel@vger.kernel.org>,
linux-input@vger.kernel.org, Wolfram Sang <wsa@the-dreams.de>
Subject: Re: [Bug 203297] Synaptics touchpad TM-3127 functionality broken by PCI runtime power management patch on 4.20.2
Date: Mon, 29 Apr 2019 11:45:38 +0200 [thread overview]
Message-ID: <1556531138.5647.1.camel@suse.de> (raw)
In-Reply-To: <CAO-hwJLCPd-KfoK7OnSpEWG4B5cYfsH3J0tYAxJeVMqHyJEN1A@mail.gmail.com>
On Mon, 2019-04-29 at 10:53 +0200, Benjamin Tissoires wrote:
> On Mon, Apr 29, 2019 at 10:38 AM Jarkko Nikula
> <jarkko.nikula@linux.intel.com> wrote:
> > I got another thought about this. I noticed these input drivers need
> > SMBus Host Notify, maybe that explain the PM dependency? If that's the
> > only dependency then we could prevent the controller suspend if there is
> > a client needing host notify mechanism. IMHO that's less hack than the
> > patch to rmi_smbus.c.
>
> So currently, AFAIK, only Synaptics (rmi4) and Elantech are using
> SMBus Host Notify.
> So this patch would prevent the same bugs for those 2 vendors, which is good.
>
> It took me some time to understand why this would be less than a hack.
> And indeed, given that Host Notify relies on the I2C connection to be
> ready for the IRQ, we can not put the controller in suspend like we do
> for others where the IRQ controller is still ready.
>
> So yes, that could work from me. Not sure what Wolfram and Jean would
> say though.
I would say OK with me, this looks like the cleanest solution to me, so
if testing is positive, let's go with it.
--
Jean Delvare
SUSE L3 Support
prev parent reply other threads:[~2019-04-29 9:45 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190422130814.GJ173520@google.com>
2019-04-26 12:12 ` [Bug 203297] Synaptics touchpad TM-3127 functionality broken by PCI runtime power management patch on 4.20.2 Jarkko Nikula
2019-04-29 7:04 ` Rafael J. Wysocki
2019-04-29 7:45 ` Benjamin Tissoires
2019-04-29 8:36 ` Jarkko Nikula
2019-04-29 8:53 ` Benjamin Tissoires
2019-04-29 9:45 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1556531138.5647.1.camel@suse.de \
--to=jdelvare@suse.de \
--cc=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=ferdasyn@rocketmail.com \
--cc=helgaas@kernel.org \
--cc=jarkko.nikula@linux.intel.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).