public inbox for linux-input@vger.kernel.org
 help / color / mirror / Atom feed
From: Bhushan Shah <bhushan.shah@machinesoul.in>
To: Krzysztof Kozlowski <krzk@kernel.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	linux-input@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] Input: edt-ft5x06 - add support for FocalTech FT3519
Date: Sat, 14 Mar 2026 19:29:45 +0530	[thread overview]
Message-ID: <15572830.uLZWGnKmhe@antlia> (raw)
In-Reply-To: <20260314-successful-nano-hyrax-cc3b21@quoll>

On Saturday, 14 March 2026 15:55:13 IST Krzysztof Kozlowski wrote:
> On Fri, Mar 13, 2026 at 12:09:51PM +0530, Bhushan Shah wrote:
> > This driver is compatible with the FocalTech FT3519 touchscreen, which
> > supports up to 10 concurrent touch points. Add a compatible for it.
> > 
> > Signed-off-by: Bhushan Shah <bhushan.shah@machinesoul.in>
> > ---
> > 
> >  drivers/input/touchscreen/edt-ft5x06.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/drivers/input/touchscreen/edt-ft5x06.c
> > b/drivers/input/touchscreen/edt-ft5x06.c index d0ab644be006..52188e1aa9bc
> > 100644
> > --- a/drivers/input/touchscreen/edt-ft5x06.c
> > +++ b/drivers/input/touchscreen/edt-ft5x06.c
> > @@ -1479,6 +1479,10 @@ static const struct edt_i2c_chip_data
> > edt_ft3518_data = {> 
> >  	.max_support_points = 10,
> >  
> >  };
> > 
> > +static const struct edt_i2c_chip_data edt_ft3519_data = {
> > +	.max_support_points = 10,
> > +};
> 
> So same as edt_ft3518_data? Why are you duplicating it then?
> 

You are right, it does not need duplicating, I sent v2 which adjusts only dt-
bindings. Although, I must point out that this driver already contains some 
duplicates and I simply followed that.



      reply	other threads:[~2026-03-14 13:59 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-13  6:39 [PATCH 0/2] Input: ft5x06: Add support for FocalTech FT3519 Bhushan Shah
2026-03-13  6:39 ` [PATCH 1/2] dt-bindings: input: touchscreen: edt-ft5x06: Add " Bhushan Shah
2026-03-14 10:29   ` Krzysztof Kozlowski
2026-03-13  6:39 ` [PATCH 2/2] Input: edt-ft5x06 - add support for " Bhushan Shah
2026-03-14 10:25   ` Krzysztof Kozlowski
2026-03-14 13:59     ` Bhushan Shah [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15572830.uLZWGnKmhe@antlia \
    --to=bhushan.shah@machinesoul.in \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=krzk+dt@kernel.org \
    --cc=krzk@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox