public inbox for linux-input@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 0/2] Input: ft5x06: Add support for FocalTech FT3519
@ 2026-03-13  6:39 Bhushan Shah
  2026-03-13  6:39 ` [PATCH 1/2] dt-bindings: input: touchscreen: edt-ft5x06: Add " Bhushan Shah
  2026-03-13  6:39 ` [PATCH 2/2] Input: edt-ft5x06 - add support for " Bhushan Shah
  0 siblings, 2 replies; 6+ messages in thread
From: Bhushan Shah @ 2026-03-13  6:39 UTC (permalink / raw)
  To: Dmitry Torokhov, Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: linux-input, devicetree, linux-kernel, Bhushan Shah

This touchscreen supports upto 10 touch points, add devicetree bindings
and compatible in driver for it.

Signed-off-by: Bhushan Shah <bhushan.shah@machinesoul.in>
---
Bhushan Shah (2):
      dt-bindings: input: touchscreen: edt-ft5x06: Add FocalTech FT3519
      Input: edt-ft5x06 - add support for FocalTech FT3519

 Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 1 +
 drivers/input/touchscreen/edt-ft5x06.c                              | 6 ++++++
 2 files changed, 7 insertions(+)
---
base-commit: 0257f64bdac7fdca30fa3cae0df8b9ecbec7733a
change-id: 20260313-edt-ft3519-b3e2a33e88ee

Best regards,
-- 
Bhushan Shah <bhushan.shah@machinesoul.in>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* [PATCH 1/2] dt-bindings: input: touchscreen: edt-ft5x06: Add FocalTech FT3519
  2026-03-13  6:39 [PATCH 0/2] Input: ft5x06: Add support for FocalTech FT3519 Bhushan Shah
@ 2026-03-13  6:39 ` Bhushan Shah
  2026-03-14 10:29   ` Krzysztof Kozlowski
  2026-03-13  6:39 ` [PATCH 2/2] Input: edt-ft5x06 - add support for " Bhushan Shah
  1 sibling, 1 reply; 6+ messages in thread
From: Bhushan Shah @ 2026-03-13  6:39 UTC (permalink / raw)
  To: Dmitry Torokhov, Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: linux-input, devicetree, linux-kernel, Bhushan Shah

Document FocalTech FT3519 support by adding the compatible. It's 10
point touchscreen, which works with same driver.

Signed-off-by: Bhushan Shah <bhushan.shah@machinesoul.in>
---
 Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
index 6f90522de8c0..34161af90156 100644
--- a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
+++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
@@ -40,6 +40,7 @@ properties:
       - edt,edt-ft5506
       - evervision,ev-ft5726
       - focaltech,ft3518
+      - focaltech,ft3519
       - focaltech,ft5426
       - focaltech,ft5452
       - focaltech,ft6236

-- 
2.53.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] Input: edt-ft5x06 - add support for FocalTech FT3519
  2026-03-13  6:39 [PATCH 0/2] Input: ft5x06: Add support for FocalTech FT3519 Bhushan Shah
  2026-03-13  6:39 ` [PATCH 1/2] dt-bindings: input: touchscreen: edt-ft5x06: Add " Bhushan Shah
@ 2026-03-13  6:39 ` Bhushan Shah
  2026-03-14 10:25   ` Krzysztof Kozlowski
  1 sibling, 1 reply; 6+ messages in thread
From: Bhushan Shah @ 2026-03-13  6:39 UTC (permalink / raw)
  To: Dmitry Torokhov, Rob Herring, Krzysztof Kozlowski, Conor Dooley
  Cc: linux-input, devicetree, linux-kernel, Bhushan Shah

This driver is compatible with the FocalTech FT3519 touchscreen, which
supports up to 10 concurrent touch points. Add a compatible for it.

Signed-off-by: Bhushan Shah <bhushan.shah@machinesoul.in>
---
 drivers/input/touchscreen/edt-ft5x06.c | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
index d0ab644be006..52188e1aa9bc 100644
--- a/drivers/input/touchscreen/edt-ft5x06.c
+++ b/drivers/input/touchscreen/edt-ft5x06.c
@@ -1479,6 +1479,10 @@ static const struct edt_i2c_chip_data edt_ft3518_data = {
 	.max_support_points = 10,
 };
 
+static const struct edt_i2c_chip_data edt_ft3519_data = {
+	.max_support_points = 10,
+};
+
 static const struct edt_i2c_chip_data edt_ft5452_data = {
 	.max_support_points = 5,
 };
@@ -1508,6 +1512,7 @@ static const struct i2c_device_id edt_ft5x06_ts_id[] = {
 	{ .name = "edt-ft5506", .driver_data = (long)&edt_ft5506_data },
 	{ .name = "ev-ft5726", .driver_data = (long)&edt_ft5506_data },
 	{ .name = "ft3518", .driver_data = (long)&edt_ft3518_data },
+	{ .name = "ft3519", .driver_data = (long)&edt_ft3519_data },
 	{ .name = "ft5452", .driver_data = (long)&edt_ft5452_data },
 	/* Note no edt- prefix for compatibility with the ft6236.c driver */
 	{ .name = "ft6236", .driver_data = (long)&edt_ft6236_data },
@@ -1525,6 +1530,7 @@ static const struct of_device_id edt_ft5x06_of_match[] = {
 	{ .compatible = "edt,edt-ft5506", .data = &edt_ft5506_data },
 	{ .compatible = "evervision,ev-ft5726", .data = &edt_ft5506_data },
 	{ .compatible = "focaltech,ft3518", .data = &edt_ft3518_data },
+	{ .compatible = "focaltech,ft3519", .data = &edt_ft3519_data },
 	{ .compatible = "focaltech,ft5426", .data = &edt_ft5506_data },
 	{ .compatible = "focaltech,ft5452", .data = &edt_ft5452_data },
 	/* Note focaltech vendor prefix for compatibility with ft6236.c */

-- 
2.53.0


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] Input: edt-ft5x06 - add support for FocalTech FT3519
  2026-03-13  6:39 ` [PATCH 2/2] Input: edt-ft5x06 - add support for " Bhushan Shah
@ 2026-03-14 10:25   ` Krzysztof Kozlowski
  2026-03-14 13:59     ` Bhushan Shah
  0 siblings, 1 reply; 6+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-14 10:25 UTC (permalink / raw)
  To: Bhushan Shah
  Cc: Dmitry Torokhov, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-input, devicetree, linux-kernel

On Fri, Mar 13, 2026 at 12:09:51PM +0530, Bhushan Shah wrote:
> This driver is compatible with the FocalTech FT3519 touchscreen, which
> supports up to 10 concurrent touch points. Add a compatible for it.
> 
> Signed-off-by: Bhushan Shah <bhushan.shah@machinesoul.in>
> ---
>  drivers/input/touchscreen/edt-ft5x06.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/drivers/input/touchscreen/edt-ft5x06.c b/drivers/input/touchscreen/edt-ft5x06.c
> index d0ab644be006..52188e1aa9bc 100644
> --- a/drivers/input/touchscreen/edt-ft5x06.c
> +++ b/drivers/input/touchscreen/edt-ft5x06.c
> @@ -1479,6 +1479,10 @@ static const struct edt_i2c_chip_data edt_ft3518_data = {
>  	.max_support_points = 10,
>  };
>  
> +static const struct edt_i2c_chip_data edt_ft3519_data = {
> +	.max_support_points = 10,
> +};

So same as edt_ft3518_data? Why are you duplicating it then?

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] dt-bindings: input: touchscreen: edt-ft5x06: Add FocalTech FT3519
  2026-03-13  6:39 ` [PATCH 1/2] dt-bindings: input: touchscreen: edt-ft5x06: Add " Bhushan Shah
@ 2026-03-14 10:29   ` Krzysztof Kozlowski
  0 siblings, 0 replies; 6+ messages in thread
From: Krzysztof Kozlowski @ 2026-03-14 10:29 UTC (permalink / raw)
  To: Bhushan Shah
  Cc: Dmitry Torokhov, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-input, devicetree, linux-kernel

On Fri, Mar 13, 2026 at 12:09:50PM +0530, Bhushan Shah wrote:
> Document FocalTech FT3519 support by adding the compatible. It's 10
> point touchscreen, which works with same driver.
> 
> Signed-off-by: Bhushan Shah <bhushan.shah@machinesoul.in>
> ---
>  Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
> index 6f90522de8c0..34161af90156 100644
> --- a/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
> +++ b/Documentation/devicetree/bindings/input/touchscreen/edt-ft5x06.yaml
> @@ -40,6 +40,7 @@ properties:
>        - edt,edt-ft5506
>        - evervision,ev-ft5726
>        - focaltech,ft3518
> +      - focaltech,ft3519

Driver clearly indicates it is compatible with 3518 so express it with
fallback (see writing bindings, writing schema, example schema, DTS101
presentation slides).

Best regards,
Krzysztof


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] Input: edt-ft5x06 - add support for FocalTech FT3519
  2026-03-14 10:25   ` Krzysztof Kozlowski
@ 2026-03-14 13:59     ` Bhushan Shah
  0 siblings, 0 replies; 6+ messages in thread
From: Bhushan Shah @ 2026-03-14 13:59 UTC (permalink / raw)
  To: Krzysztof Kozlowski
  Cc: Dmitry Torokhov, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	linux-input, devicetree, linux-kernel

On Saturday, 14 March 2026 15:55:13 IST Krzysztof Kozlowski wrote:
> On Fri, Mar 13, 2026 at 12:09:51PM +0530, Bhushan Shah wrote:
> > This driver is compatible with the FocalTech FT3519 touchscreen, which
> > supports up to 10 concurrent touch points. Add a compatible for it.
> > 
> > Signed-off-by: Bhushan Shah <bhushan.shah@machinesoul.in>
> > ---
> > 
> >  drivers/input/touchscreen/edt-ft5x06.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> > 
> > diff --git a/drivers/input/touchscreen/edt-ft5x06.c
> > b/drivers/input/touchscreen/edt-ft5x06.c index d0ab644be006..52188e1aa9bc
> > 100644
> > --- a/drivers/input/touchscreen/edt-ft5x06.c
> > +++ b/drivers/input/touchscreen/edt-ft5x06.c
> > @@ -1479,6 +1479,10 @@ static const struct edt_i2c_chip_data
> > edt_ft3518_data = {> 
> >  	.max_support_points = 10,
> >  
> >  };
> > 
> > +static const struct edt_i2c_chip_data edt_ft3519_data = {
> > +	.max_support_points = 10,
> > +};
> 
> So same as edt_ft3518_data? Why are you duplicating it then?
> 

You are right, it does not need duplicating, I sent v2 which adjusts only dt-
bindings. Although, I must point out that this driver already contains some 
duplicates and I simply followed that.



^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2026-03-14 13:59 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-13  6:39 [PATCH 0/2] Input: ft5x06: Add support for FocalTech FT3519 Bhushan Shah
2026-03-13  6:39 ` [PATCH 1/2] dt-bindings: input: touchscreen: edt-ft5x06: Add " Bhushan Shah
2026-03-14 10:29   ` Krzysztof Kozlowski
2026-03-13  6:39 ` [PATCH 2/2] Input: edt-ft5x06 - add support for " Bhushan Shah
2026-03-14 10:25   ` Krzysztof Kozlowski
2026-03-14 13:59     ` Bhushan Shah

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox