From mboxrd@z Thu Jan 1 00:00:00 1970 From: Oliver Neukum Subject: Re: WARNING in usbtouch_open Date: Tue, 30 Jul 2019 12:12:11 +0200 Message-ID: <1564481531.25582.22.camel@suse.com> References: <000000000000394df0058ed48487@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <000000000000394df0058ed48487@google.com> Sender: linux-kernel-owner@vger.kernel.org To: syzbot , rydberg@bitmath.org, mpe@ellerman.id.au, dmitry.torokhov@gmail.com, andreyknvl@google.com, syzkaller-bugs@googlegroups.com, tglx@linutronix.de, gregkh@linuxfoundation.org, kstewart@linuxfoundation.org, allison@lohutok.net, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org List-Id: linux-input@vger.kernel.org Am Montag, den 29.07.2019, 09:38 -0700 schrieb syzbot: > Hello, > > syzbot found the following crash on: > > HEAD commit: 7f7867ff usb-fuzzer: main usb gadget fuzzer driver > git tree: https://github.com/google/kasan.git usb-fuzzer > console output: https://syzkaller.appspot.com/x/log.txt?x=1503f4ec600000 > kernel config: https://syzkaller.appspot.com/x/.config?x=792eb47789f57810 > dashboard link: https://syzkaller.appspot.com/bug?extid=199ea16c7f26418b4365 > compiler: gcc (GCC) 9.0.0 20181231 (experimental) > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=173e4442600000 > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=115482b2600000 > > IMPORTANT: if you fix the bug, please add the following tag to the commit: > Reported-by: syzbot+199ea16c7f26418b4365@syzkaller.appspotmail.com #syz test: https://github.com/google/kasan.git usb-fuzzer >>From 29b755588bd353d0e10ae384c2c551dffa1b3e7b Mon Sep 17 00:00:00 2001 From: Oliver Neukum Date: Tue, 30 Jul 2019 12:00:27 +0200 Subject: [PATCH] usbtouchscreen: add proper initialization Mutexes shall be initialized before they are used. Fixes: 12e510dbc57b2 ("Input: usbtouchscreen - fix deadlock in autosuspend") Reported-by: syzbot+199ea16c7f26418b4365@syzkaller.appspotmail.com Signed-off-by: Oliver Neukum --- drivers/input/touchscreen/usbtouchscreen.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/input/touchscreen/usbtouchscreen.c b/drivers/input/touchscreen/usbtouchscreen.c index a2cec6cacf57..caacf211f51b 100644 --- a/drivers/input/touchscreen/usbtouchscreen.c +++ b/drivers/input/touchscreen/usbtouchscreen.c @@ -1658,6 +1658,7 @@ static int usbtouch_probe(struct usb_interface *intf, input_dev = input_allocate_device(); if (!usbtouch || !input_dev) goto out_free; + mutex_init(&usbtouch->pm_mutex); type = &usbtouch_dev_info[id->driver_info]; usbtouch->type = type; -- 2.16.4