From: Dixit Parmar <dixitparmar19@gmail.com>
To: dmitry.torokhov@gmail.com, rydberg@bitmath.org,
martink@posteo.de, kuninori.morimoto.gx@renesas.com,
robh@kernel.org, matthias.fend@wolfvision.net,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Dixit Parmar <dixitparmar19@gmail.com>
Subject: [PATCH] driver:st1633: fixed multitouch incorrect coordinates
Date: Mon, 19 Aug 2019 15:38:34 +0530 [thread overview]
Message-ID: <1566209314-21767-1-git-send-email-dixitparmar19@gmail.com> (raw)
From: Dixit Parmar <dixitparmar19@gmail.com>
For Sitronix st1633 multi-touch controller driver the co-ordinates reported
for multiple fingers were wrong.
So the below mentioned bug was filed,
Bugzilla Bug ID: 204561
While reading co-ordinates from specified I2C registers, the X & Y
co-ordinates should be read from proper I2C address for particular finger as
specified in chip specific datasheet.
for single touch this logic is working fine. However, for multi-touch
scenario the logic of reading data from data buffer has issues.
This patch fixes the reading logic from data buffer.
Previous logic:
* Offset of X & Y Lower byte coordinate is increased by i no. only(by 1 Byte)
for each finger.
New logic:
* The logic of reading X & Y Lower Byte coordinate needs to be increased
by i+y for each time/finger.
Signed-off-by: Dixit Parmar <dixitparmar19@gmail.com>
---
drivers/input/touchscreen/st1232.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/input/touchscreen/st1232.c b/drivers/input/touchscreen/st1232.c
index 3492339..1139714 100644
--- a/drivers/input/touchscreen/st1232.c
+++ b/drivers/input/touchscreen/st1232.c
@@ -81,8 +81,10 @@ static int st1232_ts_read_data(struct st1232_ts_data *ts)
for (i = 0, y = 0; i < ts->chip_info->max_fingers; i++, y += 3) {
finger[i].is_valid = buf[i + y] >> 7;
if (finger[i].is_valid) {
- finger[i].x = ((buf[i + y] & 0x0070) << 4) | buf[i + 1];
- finger[i].y = ((buf[i + y] & 0x0007) << 8) | buf[i + 2];
+ finger[i].x = ((buf[i + y] & 0x0070) << 4) |
+ buf[i + y + 1];
+ finger[i].y = ((buf[i + y] & 0x0007) << 8) |
+ buf[i + y + 2];
/* st1232 includes a z-axis / touch strength */
if (ts->chip_info->have_z)
--
2.7.4
next reply other threads:[~2019-08-19 10:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 10:08 Dixit Parmar [this message]
2019-08-22 12:08 ` [PATCH] driver:st1633: fixed multitouch incorrect coordinates Martin Kepplinger
2019-10-20 8:29 ` Dixit Parmar
2019-10-21 7:10 ` Martin Kepplinger
2019-10-21 17:13 ` Dmitry Torokhov
2019-10-22 8:17 ` Martin Kepplinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1566209314-21767-1-git-send-email-dixitparmar19@gmail.com \
--to=dixitparmar19@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martink@posteo.de \
--cc=matthias.fend@wolfvision.net \
--cc=robh@kernel.org \
--cc=rydberg@bitmath.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).