* [PATCH] HID: modify quirks of i2c-hid driver for weida's devices
@ 2019-08-30 7:58 hn.chen
2019-09-04 12:32 ` Jiri Kosina
0 siblings, 1 reply; 2+ messages in thread
From: hn.chen @ 2019-08-30 7:58 UTC (permalink / raw)
To: linux-input, jikos, benjamin.tissoires
Cc: linux-kernel, dmitry.torokhov, hn.chen
From: HungNien Chen <hn.chen@weidahitech.com>
This 'SET_PWR_WAKEUP_DEV' quirk only works for weida's devices with pid
0xC300 & 0xC301. Some weida's devices with other pids also need this quirk
now. Use 'HID_ANY_ID' instead of 0xC300 to make all of weida's devices can be
fixed on the power on issue. This modification should be safe since devices
without power on issue will send the power on command only once.
Signed-off-by: HungNien Chen <hn.chen@weidahitech.com>
---
drivers/hid/i2c-hid/i2c-hid-core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/hid/i2c-hid/i2c-hid-core.c b/drivers/hid/i2c-hid/i2c-hid-core.c
index 90164fe..2a7c6e3 100644
--- a/drivers/hid/i2c-hid/i2c-hid-core.c
+++ b/drivers/hid/i2c-hid/i2c-hid-core.c
@@ -169,9 +169,7 @@ struct i2c_hid {
__u16 idProduct;
__u32 quirks;
} i2c_hid_quirks[] = {
- { USB_VENDOR_ID_WEIDA, USB_DEVICE_ID_WEIDA_8752,
- I2C_HID_QUIRK_SET_PWR_WAKEUP_DEV },
- { USB_VENDOR_ID_WEIDA, USB_DEVICE_ID_WEIDA_8755,
+ { USB_VENDOR_ID_WEIDA, HID_ANY_ID,
I2C_HID_QUIRK_SET_PWR_WAKEUP_DEV },
{ I2C_VENDOR_ID_HANTICK, I2C_PRODUCT_ID_HANTICK_5288,
I2C_HID_QUIRK_NO_IRQ_AFTER_RESET |
--
1.9.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] HID: modify quirks of i2c-hid driver for weida's devices
2019-08-30 7:58 [PATCH] HID: modify quirks of i2c-hid driver for weida's devices hn.chen
@ 2019-09-04 12:32 ` Jiri Kosina
0 siblings, 0 replies; 2+ messages in thread
From: Jiri Kosina @ 2019-09-04 12:32 UTC (permalink / raw)
To: hn.chen; +Cc: linux-input, benjamin.tissoires, linux-kernel, dmitry.torokhov
On Fri, 30 Aug 2019, hn.chen@weidahitech.com wrote:
> From: HungNien Chen <hn.chen@weidahitech.com>
>
> This 'SET_PWR_WAKEUP_DEV' quirk only works for weida's devices with pid
> 0xC300 & 0xC301. Some weida's devices with other pids also need this quirk
> now. Use 'HID_ANY_ID' instead of 0xC300 to make all of weida's devices can be
> fixed on the power on issue. This modification should be safe since devices
> without power on issue will send the power on command only once.
Applied, thanks.
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-09-04 12:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-30 7:58 [PATCH] HID: modify quirks of i2c-hid driver for weida's devices hn.chen
2019-09-04 12:32 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).