public inbox for linux-input@vger.kernel.org
 help / color / mirror / Atom feed
From: haibo.chen@nxp.com
To: dmitry.torokhov@gmail.com
Cc: linux-input@vger.kernel.org, linux-imx@nxp.com, haibo.chen@nxp.com
Subject: [PATCH v2 2/2] input: egalax_ts: correct the get_firmware_command
Date: Fri, 10 Apr 2020 20:43:05 +0800	[thread overview]
Message-ID: <1586522585-14296-2-git-send-email-haibo.chen@nxp.com> (raw)
In-Reply-To: <1586522585-14296-1-git-send-email-haibo.chen@nxp.com>

From: Haibo Chen <haibo.chen@nxp.com>

According to the User Guide, the get firmware command is
{ 0x03, 0x03, 0xa, 0x01, 'D' }, ASCII value of 'D' is 0x44.

Signed-off-by: Haibo Chen <haibo.chen@nxp.com>
---
 drivers/input/touchscreen/egalax_ts.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/input/touchscreen/egalax_ts.c b/drivers/input/touchscreen/egalax_ts.c
index c816e03ba421..bb0a59d19f34 100644
--- a/drivers/input/touchscreen/egalax_ts.c
+++ b/drivers/input/touchscreen/egalax_ts.c
@@ -171,10 +171,10 @@ static int egalax_wake_up_device(struct i2c_client *client)
 
 static int egalax_firmware_version(struct i2c_client *client)
 {
-	static const u8 cmd[MAX_I2C_DATA_LEN] = { 0x03, 0x03, 0xa, 0x01, 0x41 };
+	static const u8 get_firmware_cmd[MAX_I2C_DATA_LEN] = { 0x03, 0x03, 0xa, 0x01, 0x44 };
 	int ret;
 
-	ret = i2c_master_send(client, cmd, MAX_I2C_DATA_LEN);
+	ret = i2c_master_send(client, get_firmware_cmd, MAX_I2C_DATA_LEN);
 	if (ret < 0)
 		return ret;
 
-- 
2.17.1


  reply	other threads:[~2020-04-10 12:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-04-10 12:43 [PATCH v2 1/2] input: egalax_ts: free irq resource before request the line as GPIO haibo.chen
2020-04-10 12:43 ` haibo.chen [this message]
2020-04-10 13:01   ` [PATCH v2 2/2] input: egalax_ts: correct the get_firmware_command Fabio Estevam
2020-04-10 13:18     ` BOUGH CHEN

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1586522585-14296-2-git-send-email-haibo.chen@nxp.com \
    --to=haibo.chen@nxp.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-imx@nxp.com \
    --cc=linux-input@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox