From: Arnd Bergmann <arnd@arndb.de>
To: Laxman Dewangan <ldewangan@nvidia.com>
Cc: Alexander Stein <alexander.stein@systec-electronic.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
linux-input@vger.kernel.org, devicetree@vger.kernel.org,
linux-gpio@vger.kernel.org
Subject: Re: [PATCH v2 1/1] Input: gpio_keys - add device tree support for interrupt only keys
Date: Thu, 13 Nov 2014 12:05:26 +0100 [thread overview]
Message-ID: <1587930.UcHkd3vGmk@wuerfel> (raw)
In-Reply-To: <54648EF6.10402@nvidia.com>
On Thursday 13 November 2014 16:29:02 Laxman Dewangan wrote:
> On Thursday 13 November 2014 04:17 PM, Arnd Bergmann wrote:
> > I notice that Laxman Dewangan initially added the feature as part of
> > (I assume) work on Tegra, but these days Tegra is DT-only so it can't
> > actually get used for that any more.
> >
> > If we have a real usecase, I think we can still take your patch, but
> > my impression at the moment is that it may be better to instead
> > remove the feature entirely by reverting d8ee4a1c9052 ("Input:
> > gpio_keys - add support for interrupt only keys").
> >
> > Regarding your initial use case of testing interrupt polarity, would
> > you have been able to do the same thing by looking at the interrupt
> > count in /proc/interrupts?
> >
>
> Yes, I posted patch for interrupt key on context on key connected to
> PMIC-Onkey.
> On PMIC, there is onkey pin input which generates interrupt only when it
> toggles. So if we have key (power key on our platforms) connected to
> this pin then we will only get interrupt from PMIC.
> Instead of implementing full interrupt key driver, I added this support
> on existing gpio keys.
So is this code still in place, and do you think it's worthwhile to
have a DT binding for it?
Could the PMIC register a gpio controller instead?
Arnd
next prev parent reply other threads:[~2014-11-13 11:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-11-12 16:02 [PATCH v2 1/1] Input: gpio_keys - add device tree support for interrupt only keys Alexander Stein
2014-11-12 16:04 ` Arnd Bergmann
2014-11-12 16:38 ` Alexander Stein
2014-11-12 19:16 ` Arnd Bergmann
2014-11-13 10:35 ` Alexander Stein
2014-11-13 10:47 ` Arnd Bergmann
2014-11-13 10:52 ` Alexander Stein
2014-11-13 11:00 ` Arnd Bergmann
2014-11-13 11:02 ` Laxman Dewangan
2014-11-13 10:59 ` Laxman Dewangan
2014-11-13 11:05 ` Arnd Bergmann [this message]
2014-11-13 11:17 ` Laxman Dewangan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1587930.UcHkd3vGmk@wuerfel \
--to=arnd@arndb.de \
--cc=alexander.stein@systec-electronic.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=ldewangan@nvidia.com \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).