* [PATCH] Input: synaptics-rmi4 - remove the useless unsigned variable compared with zero
@ 2020-11-23 6:37 xiakaixu1987
0 siblings, 0 replies; only message in thread
From: xiakaixu1987 @ 2020-11-23 6:37 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: linux-input, linux-kernel, Kaixu Xia
From: Kaixu Xia <kaixuxia@tencent.com>
It is always true that the value of unsigned variable size_presence_reg
greater than or equal to zero, so compared with zero is unnecessary.
Remove it.
Reported-by: Tosk Robot <tencent_os_robot@tencent.com>
Signed-off-by: Kaixu Xia <kaixuxia@tencent.com>
---
drivers/input/rmi4/rmi_driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/input/rmi4/rmi_driver.c b/drivers/input/rmi4/rmi_driver.c
index 258d5fe3d395..e7c9300417e3 100644
--- a/drivers/input/rmi4/rmi_driver.c
+++ b/drivers/input/rmi4/rmi_driver.c
@@ -580,7 +580,7 @@ int rmi_read_register_desc(struct rmi_device *d, u16 addr,
return ret;
++addr;
- if (size_presence_reg < 0 || size_presence_reg > 35)
+ if (size_presence_reg > 35)
return -EIO;
memset(buf, 0, sizeof(buf));
--
2.20.0
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2020-11-23 6:37 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-11-23 6:37 [PATCH] Input: synaptics-rmi4 - remove the useless unsigned variable compared with zero xiakaixu1987
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).