From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 473FD31BCBC for ; Thu, 16 Oct 2025 11:57:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760615844; cv=none; b=VUCntfmHYKFkiTf3MYK2WAG3yvofipxGM24MmYPAE3nF8Hg+mKMIEq5ZIs4vBAqrxbZKu+tVvPIEqQZD+y+8txnxrISErf/GBT9c4gUq/0m1mKQKzdd9ggG7NVq0SGXPUDkLbiu0tcJqtK4jnVAXhly4Urn8c54Ne9m87HXt2d8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1760615844; c=relaxed/simple; bh=sRF5+eiyyvDy6P35qPDSbZ1Op+KomFN+cO3tpPaTpzU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QNYHAvr20hnXpSC0FQPPE49D4V/p5AGAxkPVqc0zOmFkqaQwZWbzdPrJeEXkMJP1AdpJ+1b8bhkuh/CvwimOTn5RUP7LMzp8zBYm7thWHc0kDH5WZ4uUV6RGCjnd6HFqhK4UA2F0YylHIqlZeHVabTgjgvLL3b3CuXcgWvpMbkg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dfcK2pKv; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dfcK2pKv" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-47109187c32so3335755e9.2 for ; Thu, 16 Oct 2025 04:57:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760615840; x=1761220640; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ArYuqC9d/+uAAMAhpyNsnKi2KHyS/I3ASJZL/VZkmq8=; b=dfcK2pKvABcBngobcpn9bxLPHj1BNp3/TEONd6n5S/U8Pc9aN2y6sEeLI0TmxwZxDn SekQ+9e7MuFKQ0aW5e/rhwiwoJ+IOt2lnH7tA1ytzBIWvTePmjqgvk2YKJ/OYbncewvm oMqOBOCIpUarE98Iin0xaYTPJPvsLcF2x64W+BitdIhBpocgOBNT8Zo9693wz9E5mNK9 8nndjyyWuyyk+Amii3eCr9YWYlf9+Xc2WZ97DdiHfsPqd9MOZMKajPqWVH7kKc358FS1 mAgvh01vAUPbA2R6Jm3iIRUZcwkM1iKVc99prQWDe9YmTkVazwoiu8DkWhj9/OVC+gZ+ JnjQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760615840; x=1761220640; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ArYuqC9d/+uAAMAhpyNsnKi2KHyS/I3ASJZL/VZkmq8=; b=KqYH4naxoLQTiEDtOpNfjT5llSh9RpG7EOXKMB77XKfGVsn15nzyk6fQoRyYFfg+Gq lrEq3cH88qbzSE0yFfVS6d2UQGLKehTR90zh0czN4kZezwihqyP7GY82iOUaUfnoBs+8 X6wJHm8ghoSSnjQ5+mUnl7N+pMfUBXXb5pns1ikPer+Yf34yzccw96wqZK7g9Vnl9h6a 4OhJsVy66lBExN8O+4bxQ0IIWAlKdfHxIbDLIBD7+D9UUnFZbPyURSmGQ0ACbngHn+zx 1vwzt/wButO9UwZlTIUcgX7k95IwiXFjHxWtElWW6+XpPvs31Pf6R/gwqIaNtgnBVqSq JqeQ== X-Forwarded-Encrypted: i=1; AJvYcCUQKd0sMpfdivcKq7lNXvKUelyZabkC5q6V02LkrjTw5JfR+4gbioDnqdNaJob+cPWqMVGDAQIZDSDQAA==@vger.kernel.org X-Gm-Message-State: AOJu0YxnOGwI0FynZ3KigtgNKV9wFmOWCDlw5ZafkHTMnS6wKvzOZw/q AmQwiKVXNpmgdU+2D6t4ttH0xJ4x0m/zEJG0jS9yXPDoTvEE/J2sK4WF X-Gm-Gg: ASbGncvyk2g/XlM8LlXyo+cyzUO91uRkvbccSvA19jovgl8hKWF9acTeyJfkPLF+2v4 LuFoCzVr86qitH/8m7V/bFvv0HIQ8N05kgcXFkSXCBhgOsKs1Lshii7VHj2CPnJs9XiqgE85Hq1 /uQiBbeTYsB7WHqERIq8lClKXpav09XvwRzHzfAwR1ZVhtzIHygJcA4+Q0c/9P5qa/pomm6m1+L vVBVCbSdWJZyavj09l8lB+no1Vm2egz2F/jGNWASGarPbfToqGzock0a8UzVgSQRc31E4pYxTdQ oSNCDI+W10aIdizWcqS2AXQ6pWgrwUGt5wLlYk+ekcWZM+/2Pda9hTzqoSCdtP9Ft0z/DAJrr3N R6HiKqGldGRgq5sm3f4etZhXsxOZ2vjCF3haglkni6nTwUz4oC180VH1ZSOJDfI6l2fpZWjPpJ6 EtaECiKYsN6t2ptohg0uz4C0At X-Google-Smtp-Source: AGHT+IELWh2FOBUasPrU4o/JTA9HAOtjaMyk6lZtLqKGYpqZSBBmNutJ4eN0jpuLE9Huxd8ZS6tGJA== X-Received: by 2002:a05:600c:c0d6:b0:471:c04:a352 with SMTP id 5b1f17b1804b1-4710c04a443mr17476155e9.4.1760615840293; Thu, 16 Oct 2025 04:57:20 -0700 (PDT) Received: from [192.168.1.121] ([176.206.100.218]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47114444b06sm22459765e9.12.2025.10.16.04.57.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Oct 2025 04:57:19 -0700 (PDT) Message-ID: <160c3adf-9333-4486-ba4c-d3359ea73337@gmail.com> Date: Thu, 16 Oct 2025 13:57:19 +0200 Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v6 0/7] HID: asus: Fix ASUS ROG Laptop's Keyboard backlight handling To: Antheas Kapenekakis , platform-driver-x86@vger.kernel.org, linux-input@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Jiri Kosina , Benjamin Tissoires , Corentin Chary , "Luke D . Jones" , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= References: <20251013201535.6737-1-lkml@antheas.dev> Content-Language: en-US, it-IT, en-US-large From: Denis Benato In-Reply-To: <20251013201535.6737-1-lkml@antheas.dev> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 10/13/25 22:15, Antheas Kapenekakis wrote: > This is a two part series which does the following: > - Clean-up init sequence > - Unify backlight handling to happen under asus-wmi so that all Aura > devices have synced brightness controls and the backlight button works > properly when it is on a USB laptop keyboard instead of one w/ WMI. > > For more context, see cover letter of V1. Since V5, I removed some patches > to make this easier to merge. > > All comments with these patches had been addressed since V4. I have loaded this patchset for users of asus-linux project to try out. One of them opened a bug report about a kernel bug that happens consistently when closing the lid of his laptop [1]. He also sent another piece of kernel log, but didn't specify anything more about this [2]. [1] https://pastebin.com/akZx1w10 [2] https://pastebin.com/sKdczPgf > --- > V5: https://lore.kernel.org/all/20250325184601.10990-1-lkml@antheas.dev/ > V4: https://lore.kernel.org/lkml/20250324210151.6042-1-lkml@antheas.dev/ > V3: https://lore.kernel.org/lkml/20250322102804.418000-1-lkml@antheas.dev/ > V2: https://lore.kernel.org/all/20250320220924.5023-1-lkml@antheas.dev/ > V1: https://lore.kernel.org/all/20250319191320.10092-1-lkml@antheas.dev/ > > Changes since V5: > - It's been a long time > - Remove addition of RGB as that had some comments I need to work on > - Remove folio patch (already merged) > - Remove legacy fix patch 11 from V4. There is a small chance that > without this patch, some old NKEY keyboards might not respond to > RGB commands according to Luke, but the kernel driver does not do > RGB currently. The 0x5d init is done by Armoury crate software in > Windows. If an issue is found, we can re-add it or just remove patches > 1/2 before merging. However, init could use the cleanup. > > Changes since V4: > - Fix KConfig (reported by kernel robot) > - Fix Ilpo's nits, if I missed anything lmk > > Changes since V3: > - Add initializer for 0x5d for old NKEY keyboards until it is verified > that it is not needed for their media keys to function. > - Cover init in asus-wmi with spinlock as per Hans > - If asus-wmi registers WMI handler with brightness, init the brightness > in USB Asus keyboards, per Hans. > - Change hid handler name to asus-UNIQ:rgb:peripheral to match led class > - Fix oops when unregistering asus-wmi by moving unregister outside of > the spin lock (but after the asus reference is set to null) > > Changes since V2: > - Check lazy init succeds in asus-wmi before setting register variable > - make explicit check in asus_hid_register_listener for listener existing > to avoid re-init > - rename asus_brt to asus_hid in most places and harmonize everything > - switch to a spinlock instead of a mutex to avoid kernel ooops > - fixup hid device quirks to avoid multiple RGB devices while still exposing > all input vendor devices. This includes moving rgb init to probe > instead of the input_configured callbacks. > - Remove fan key (during retest it appears to be 0xae that is already > supported by hid-asus) > - Never unregister asus::kbd_backlight while asus-wmi is active, as that > - removes fds from userspace and breaks backlight functionality. All > - current mainline drivers do not support backlight hotplugging, so most > userspace software (e.g., KDE, UPower) is built with that assumption. > For the Ally, since it disconnects its controller during sleep, this > caused the backlight slider to not work in KDE. > > Changes since V1: > - Add basic RGB support on hid-asus, (Z13/Ally) tested in KDE/Z13 > - Fix ifdef else having an invalid signature (reported by kernel robot) > - Restore input arguments to init and keyboard function so they can > be re-used for RGB controls. > - Remove Z13 delay (it did not work to fix the touchpad) and replace it > with a HID_GROUP_GENERIC quirk to allow hid-multitouch to load. Squash > keyboard rename into it. > - Unregister brightness listener before removing work queue to avoid > a race condition causing corruption > - Remove spurious mutex unlock in asus_brt_event > - Place mutex lock in kbd_led_set after LED_UNREGISTERING check to avoid > relocking the mutex and causing a deadlock when unregistering leds > - Add extra check during unregistering to avoid calling unregister when > no led device is registered. > - Temporarily HID_QUIRK_INPUT_PER_APP from the ROG endpoint as it causes > the driver to create 4 RGB handlers per device. I also suspect some > extra events sneak through (KDE had the @@@@@@). > > Antheas Kapenekakis (7): > HID: asus: refactor init sequence per spec > HID: asus: prevent binding to all HID devices on ROG > platform/x86: asus-wmi: Add support for multiple kbd RGB handlers > HID: asus: listen to the asus-wmi brightness device instead of > creating one > platform/x86: asus-wmi: remove unused keyboard backlight quirk > platform/x86: asus-wmi: add keyboard brightness event handler > HID: asus: add support for the asus-wmi brightness handler > > drivers/hid/hid-asus.c | 235 +++++++++++---------- > drivers/platform/x86/asus-wmi.c | 157 ++++++++++++-- > include/linux/platform_data/x86/asus-wmi.h | 69 +++--- > 3 files changed, 291 insertions(+), 170 deletions(-) > > > base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787