* [PATCH] HID: hiddev: return -ENOMEM when kmalloc failed
@ 2021-04-26 9:35 Yang Li
2021-04-26 12:13 ` Johan Hovold
0 siblings, 1 reply; 2+ messages in thread
From: Yang Li @ 2021-04-26 9:35 UTC (permalink / raw)
To: jikos; +Cc: benjamin.tissoires, linux-usb, linux-input, linux-kernel, Yang Li
The driver is using -1 instead of the -ENOMEM defined macro to
specify that a buffer allocation failed. Using the correct error
code is more intuitive.
Smatch tool warning:
drivers/hid/usbhid/hiddev.c:894 hiddev_connect() warn: returning -1
instead of -ENOMEM is sloppy
No functional change, just more standardized.
Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
---
drivers/hid/usbhid/hiddev.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c
index 45e0b1c..88020f3 100644
--- a/drivers/hid/usbhid/hiddev.c
+++ b/drivers/hid/usbhid/hiddev.c
@@ -891,7 +891,7 @@ int hiddev_connect(struct hid_device *hid, unsigned int force)
}
if (!(hiddev = kzalloc(sizeof(struct hiddev), GFP_KERNEL)))
- return -1;
+ return -ENOMEM;
init_waitqueue_head(&hiddev->wait);
INIT_LIST_HEAD(&hiddev->list);
--
1.8.3.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] HID: hiddev: return -ENOMEM when kmalloc failed
2021-04-26 9:35 [PATCH] HID: hiddev: return -ENOMEM when kmalloc failed Yang Li
@ 2021-04-26 12:13 ` Johan Hovold
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hovold @ 2021-04-26 12:13 UTC (permalink / raw)
To: Yang Li; +Cc: jikos, benjamin.tissoires, linux-usb, linux-input, linux-kernel
On Mon, Apr 26, 2021 at 05:35:26PM +0800, Yang Li wrote:
> The driver is using -1 instead of the -ENOMEM defined macro to
> specify that a buffer allocation failed. Using the correct error
> code is more intuitive.
>
> Smatch tool warning:
> drivers/hid/usbhid/hiddev.c:894 hiddev_connect() warn: returning -1
> instead of -ENOMEM is sloppy
>
> No functional change, just more standardized.
>
> Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
> ---
> drivers/hid/usbhid/hiddev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/hid/usbhid/hiddev.c b/drivers/hid/usbhid/hiddev.c
> index 45e0b1c..88020f3 100644
> --- a/drivers/hid/usbhid/hiddev.c
> +++ b/drivers/hid/usbhid/hiddev.c
> @@ -891,7 +891,7 @@ int hiddev_connect(struct hid_device *hid, unsigned int force)
> }
>
> if (!(hiddev = kzalloc(sizeof(struct hiddev), GFP_KERNEL)))
> - return -1;
> + return -ENOMEM;
Please try to understand the code that you're changing based on feedback
from some tool.
All other error paths here return -1 and the return value of this
function is only compared to zero.
How is changing only one of these paths an improvement in any way?
>
> init_waitqueue_head(&hiddev->wait);
> INIT_LIST_HEAD(&hiddev->list);
Johan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-04-26 12:13 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-04-26 9:35 [PATCH] HID: hiddev: return -ENOMEM when kmalloc failed Yang Li
2021-04-26 12:13 ` Johan Hovold
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).