From: Sven Eckelmann <sven@narfation.org>
To: simon@mungewell.org
Cc: linux-input@vger.kernel.org, Jiri Kosina <jkosina@suse.cz>,
Colin Leitner <colin.leitner@gmail.com>
Subject: Re: Re: Re: [PATCH] HID: sony: Add force feedback support for Dualshock3 USB
Date: Sun, 17 Nov 2013 18:41:49 +0100 [thread overview]
Message-ID: <1630060.CRNYjFIevc@sven-desktop> (raw)
In-Reply-To: <35271d19bf566dcc8d07fdb07d3c5830.squirrel@mungewell.org>
[-- Attachment #1: Type: text/plain, Size: 530 bytes --]
On Sunday 17 November 2013 12:38:43 simon@mungewell.org wrote:
> > So it is a bad choice to use hid_output_raw_report (which calls
> > usb_control_msg) in a ff_memless control function. I will just send a
> > revert
> > patch in some minutes.
>
> Rather than revert, can't we just replace the raw call with
> 'hid_hw_request()' to send the data?
This device doesn't have any report and I had not the time to check how to
correctly generate the fields manually for the report/check why it doesn't
have any.
Kind regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2013-11-17 17:41 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-11-09 18:25 [PATCH] HID: sony: Add force feedback support for Dualshock3 USB Sven Eckelmann
2013-11-11 10:26 ` Jiri Kosina
2013-11-16 22:30 ` simon
2013-11-17 1:48 ` simon
2013-11-17 9:36 ` Sven Eckelmann
2013-11-17 16:30 ` David Herrmann
2013-11-17 18:08 ` Sven Eckelmann
2013-11-17 19:11 ` simon
2013-11-17 17:38 ` simon
2013-11-17 17:41 ` Sven Eckelmann [this message]
2013-11-17 22:25 ` Antonio Ospite
2013-11-17 23:12 ` Sven Eckelmann
2013-11-17 23:53 ` Sven Eckelmann
2013-11-18 0:26 ` Sven Eckelmann
2013-11-18 1:21 ` simon
2013-11-18 3:54 ` simon
2013-11-18 10:27 ` Antonio Ospite
2013-11-18 15:27 ` Antonio Ospite
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1630060.CRNYjFIevc@sven-desktop \
--to=sven@narfation.org \
--cc=colin.leitner@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=simon@mungewell.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).