From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-input-owner@vger.kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from vger.kernel.org (vger.kernel.org [23.128.96.18])
	by smtp.lore.kernel.org (Postfix) with ESMTP id CA8A1CE7A9F
	for <linux-input@archiver.kernel.org>; Mon, 25 Sep 2023 16:25:14 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S230049AbjIYQZT (ORCPT <rfc822;linux-input@archiver.kernel.org>);
        Mon, 25 Sep 2023 12:25:19 -0400
Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48790 "EHLO
        lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S229437AbjIYQZS (ORCPT
        <rfc822;linux-input@vger.kernel.org>);
        Mon, 25 Sep 2023 12:25:18 -0400
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
        by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 046DDBE;
        Mon, 25 Sep 2023 09:25:12 -0700 (PDT)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id A0251C433C8;
        Mon, 25 Sep 2023 16:25:10 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
        s=k20201202; t=1695659111;
        bh=k44ZVpNI7Cq7j38SfPe5poWW99evd2e78ncnRvDGIGU=;
        h=Date:From:To:Cc:Subject:References:In-Reply-To:From;
        b=SCG1NXeKouPC7336hAAj5rxp1TD7jepacPz8lMaAcry8WDFMqziGPKh/bUQ28hBp6
         qNOCEHGkT3HPYNlYR3gTKZeUFUWSUZfxxCgJArLTWYaFhyUh5/RuggBQtmN3MlJ/eO
         DboMVh5/khCO0nd2dkpHvW3m1Uf71ZhJcK6S9TEqSZaiXjPnsZgs+1yRTKaitbT5R/
         EH4OZOdE8YPGlR67hxEJRkk5Ka+iECOOncmTo3OG4m9WPPgMFPJvMUUlUgKwPvom7A
         v845EvVBo4i2h3lPEBvJiCO1bAxGXY54U1cfP3HhbwuXmZ8FMC9xAq1rdzlltRkRuf
         7uEpdd45B9eDQ==
Received: (nullmailer pid 1468913 invoked by uid 1000);
        Mon, 25 Sep 2023 16:25:09 -0000
Date:   Mon, 25 Sep 2023 11:25:09 -0500
From:   Rob Herring <robh@kernel.org>
To:     Luca Ceresoli <luca.ceresoli@bootlin.com>
Cc:     linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
        Dmitry Torokhov <dmitry.torokhov@gmail.com>,
        Rob Herring <robh+dt@kernel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
        Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
        Jeff LaBundy <jeff@labundy.com>, devicetree@vger.kernel.org,
        Conor Dooley <conor+dt@kernel.org>
Subject: Re: [PATCH v2] dt-bindings: input: touchscreen: goodix: clarify
 irq-gpios misleading text
Message-ID: <169565910910.1468857.379234431707593994.robh@kernel.org>
References: <20230925032208.11698-1-luca.ceresoli@bootlin.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20230925032208.11698-1-luca.ceresoli@bootlin.com>
Precedence: bulk
List-ID: <linux-input.vger.kernel.org>
X-Mailing-List: linux-input@vger.kernel.org


On Mon, 25 Sep 2023 05:22:08 +0200, Luca Ceresoli wrote:
> The irq-gpios description misleading, apparently saying that driving the
> IRQ GPIO resets the device, which is even more puzzling as there is a reset
> GPIO as well.
> 
> In reality the IRQ pin can be driven during the reset sequence to configure
> the client address, as it becomes clear after checking both the datasheet
> and the driver code. Improve the text to clarify that.
> 
> Also rephrase to remove reference to the driver, which is not appropriate
> in the bindings.
> 
> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>
> 
> ---
> 
> Changed in v2:
>  - reworded to clarify even further
> ---
>  .../devicetree/bindings/input/touchscreen/goodix.yaml        | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 

Acked-by: Rob Herring <robh@kernel.org>