From: Benjamin Tissoires <bentiss@kernel.org>
To: jikos@kernel.org, benjamin.tissoires@redhat.com, jm@lentin.co.uk,
linux-kernel@vger.kernel.org,
Martin Kepplinger <martink@posteo.de>
Cc: linux-input@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] hid: lenovo: Resend all settings on reset_resume for compact keyboards
Date: Wed, 25 Oct 2023 21:01:31 +0200 [thread overview]
Message-ID: <169826049199.324677.14789310817428601000.b4-ty@kernel.org> (raw)
In-Reply-To: <20231002150914.22101-1-martink@posteo.de>
On Mon, 02 Oct 2023 15:09:14 +0000, Martin Kepplinger wrote:
> The USB Compact Keyboard variant requires a reset_resume function to
> restore keyboard configuration after a suspend in some situations. Move
> configuration normally done on probe to lenovo_features_set_cptkbd(), then
> recycle this for use on reset_resume.
>
> Without, the keyboard and driver would end up in an inconsistent state,
> breaking middle-button scrolling amongst other problems, and twiddling
> sysfs values wouldn't help as the middle-button mode won't be set until
> the driver is reloaded.
>
> [...]
Applied to hid/hid.git (for-6.7/lenovo), thanks!
[1/1] hid: lenovo: Resend all settings on reset_resume for compact keyboards
https://git.kernel.org/hid/hid/c/2f2bd7cbd1d1
Cheers,
--
Benjamin Tissoires <bentiss@kernel.org>
prev parent reply other threads:[~2023-10-25 19:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-02 15:09 [PATCH] hid: lenovo: Resend all settings on reset_resume for compact keyboards Martin Kepplinger
2023-10-12 7:51 ` Martin Kepplinger
2023-10-24 8:55 ` Martin Kepplinger
2023-10-25 19:01 ` Benjamin Tissoires [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=169826049199.324677.14789310817428601000.b4-ty@kernel.org \
--to=bentiss@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=jm@lentin.co.uk \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martink@posteo.de \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox