Re: [PATCH] Input: egalax_ts - Provide a .remove function

[Dmitry Torokhov <dmitry.torokhov@gmail.com>]

Hi Fabio,

On Wednesday, July 24, 2013 05:46:09 PM Fabio Estevam wrote:
> Provide a .remove function so that we can unregister the input device.
> 
> Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
> ---
>  drivers/input/touchscreen/egalax_ts.c | 11 +++++++++++
>  1 file changed, 11 insertions(+)
> 
> diff --git a/drivers/input/touchscreen/egalax_ts.c
> b/drivers/input/touchscreen/egalax_ts.c index ef5fcb0..e46be61 100644
> --- a/drivers/input/touchscreen/egalax_ts.c
> +++ b/drivers/input/touchscreen/egalax_ts.c
> @@ -234,6 +234,16 @@ static int egalax_ts_probe(struct i2c_client *client,
>  	return 0;
>  }
> 
> +static int egalax_ts_remove(struct i2c_client *client)
> +{
> +	struct egalax_ts *ts = i2c_get_clientdata(client);
> +
> +	input_unregister_device(ts->input_dev);
> +	kfree(ts);


The egalax_ts driver has been converted to devm* infrastructure, using kfree() 
to free memory not only unnecessary, but wrong.

Thanks.

-- 
Dmitry