From: Erni Sri Satya Vennela <ernis@linux.microsoft.com>
To: kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org,
decui@microsoft.com, jikos@kernel.org, bentiss@kernel.org,
dmitry.torokhov@gmail.com, linux-hyperv@vger.kernel.org,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: ernis@microsoft.com,
Erni Sri Satya Vennela <ernis@linux.microsoft.com>,
Saurabh Sengar <ssengar@linux.microsoft.com>
Subject: [PATCH 1/3] Drivers: hv: vmbus: Disable Suspend-to-Idle for VMBus
Date: Thu, 12 Sep 2024 14:27:48 -0700 [thread overview]
Message-ID: <1726176470-13133-2-git-send-email-ernis@linux.microsoft.com> (raw)
In-Reply-To: <1726176470-13133-1-git-send-email-ernis@linux.microsoft.com>
If the Virtual Machine Connection window is focused,
a Hyper-V VM user can unintentionally touch the keyboard/mouse
when the VM is hibernating or resuming, and consequently the
hibernation or resume operation can be aborted unexpectedly.
Fix the issue by no longer registering the keyboard/mouse as
wakeup devices (see the other two patches for the
changes to drivers/input/serio/hyperv-keyboard.c and
drivers/hid/hid-hyperv.c).
The keyboard/mouse were registered as wakeup devices because the
VM needs to be woken up from the Suspend-to-Idle state after
a user runs "echo freeze > /sys/power/state". It seems like
the Suspend-to-Idle feature has no real users in practice, so
let's no longer support that by returning -EOPNOTSUPP if a
user tries to use that.
Signed-off-by: Saurabh Sengar <ssengar@linux.microsoft.com>
Signed-off-by: Erni Sri Satya Vennela <ernis@linux.microsoft.com>
---
drivers/hv/vmbus_drv.c | 15 ++++++++++++++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/hv/vmbus_drv.c b/drivers/hv/vmbus_drv.c
index 965d2a4efb7e..4efd8856392f 100644
--- a/drivers/hv/vmbus_drv.c
+++ b/drivers/hv/vmbus_drv.c
@@ -900,6 +900,19 @@ static void vmbus_shutdown(struct device *child_device)
}
#ifdef CONFIG_PM_SLEEP
+/*
+ * vmbus_freeze - Suspend-to-Idle
+ */
+static int vmbus_freeze(struct device *child_device)
+{
+/*
+ * Do not support Suspend-to-Idle ("echo freeze > /sys/power/state") as
+ * that would require registering the Hyper-V synthetic mouse/keyboard
+ * devices as wakeup devices, which can abort hibernation/resume unexpectedly.
+ */
+ return -EOPNOTSUPP;
+}
+
/*
* vmbus_suspend - Suspend a vmbus device
*/
@@ -969,7 +982,7 @@ static void vmbus_device_release(struct device *device)
*/
static const struct dev_pm_ops vmbus_pm = {
- .suspend_noirq = NULL,
+ .suspend_noirq = vmbus_freeze,
.resume_noirq = NULL,
.freeze_noirq = vmbus_suspend,
.thaw_noirq = vmbus_resume,
--
2.34.1
next prev parent reply other threads:[~2024-09-12 21:28 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-12 21:27 [PATCH 0/3] Disable Suspend-to-Idle in Hyper-V and Fix Hibernation Interruptions Erni Sri Satya Vennela
2024-09-12 21:27 ` Erni Sri Satya Vennela [this message]
2024-09-13 6:38 ` [PATCH 1/3] Drivers: hv: vmbus: Disable Suspend-to-Idle for VMBus Saurabh Singh Sengar
2024-09-13 7:19 ` Naman Jain
2024-09-21 19:09 ` Erni Sri Satya Vennela
2024-09-13 17:01 ` kernel test robot
2024-09-13 17:43 ` kernel test robot
2024-09-24 3:27 ` Srivatsa S. Bhat
2024-09-12 21:27 ` [PATCH 2/3] Revert "Input: hyperv-keyboard - register as a wakeup source" Erni Sri Satya Vennela
2024-09-24 3:28 ` Srivatsa S. Bhat
2024-10-04 8:14 ` Dmitry Torokhov
2024-10-17 13:44 ` Erni Sri Satya Vennela
2024-11-08 10:47 ` Erni Sri Satya Vennela
2024-12-09 17:16 ` Saurabh Singh Sengar
2024-12-12 14:33 ` Erni Sri Satya Vennela
2024-09-12 21:27 ` [PATCH 3/3] Revert "HID: hyperv: " Erni Sri Satya Vennela
2024-09-24 3:29 ` Srivatsa S. Bhat
2024-09-24 3:26 ` [PATCH 0/3] Disable Suspend-to-Idle in Hyper-V and Fix Hibernation Interruptions Srivatsa S. Bhat
2024-09-26 3:45 ` Erni Sri Satya Vennela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1726176470-13133-2-git-send-email-ernis@linux.microsoft.com \
--to=ernis@linux.microsoft.com \
--cc=bentiss@kernel.org \
--cc=decui@microsoft.com \
--cc=dmitry.torokhov@gmail.com \
--cc=ernis@microsoft.com \
--cc=haiyangz@microsoft.com \
--cc=jikos@kernel.org \
--cc=kys@microsoft.com \
--cc=linux-hyperv@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ssengar@linux.microsoft.com \
--cc=wei.liu@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).