linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Rob Herring (Arm)" <robh@kernel.org>
To: Dzmitry Sankouski <dsankouski@gmail.com>
Cc: Lee Jones <lee@kernel.org>, Chanwoo Choi <cw00.choi@samsung.com>,
	 Sebastian Reichel <sre@kernel.org>,
	linux-kernel@vger.kernel.org,  devicetree@vger.kernel.org,
	Dmitry Torokhov <dmitry.torokhov@gmail.com>,
	 Krzysztof Kozlowski <krzk@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,  Pavel Machek <pavel@ucw.cz>,
	linux-input@vger.kernel.org,  linux-pm@vger.kernel.org,
	linux-leds@vger.kernel.org
Subject: Re: [PATCH v7 2/7] dt-bindings: mfd: add maxim,max77705
Date: Wed, 23 Oct 2024 15:35:10 -0500	[thread overview]
Message-ID: <172971571004.1852226.15537632667573865513.robh@kernel.org> (raw)
In-Reply-To: <20241023-starqltechn_integration_upstream-v7-2-9bfaa3f4a1a0@gmail.com>


On Wed, 23 Oct 2024 22:42:50 +0300, Dzmitry Sankouski wrote:
> Add maxim,max77705 core binding part.
> 
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> Signed-off-by: Dzmitry Sankouski <dsankouski@gmail.com>
> ---
> Changes in v6:
> - unevaluatedProperties must be false
> - drop excessive sentence from description,
>   just describe the device
> - change leds compatible to maxim,max77705-rgb
> 
> Changes in v5:
> - formatting changes
> - add unevaluatedProperties: false for nodes referencing
>   common schemas
> - remove additionalProperties on nodes with
>   unevaluatedProperties: false
> - add min and max to led index
> Changes in v4:
> - change dts example intendation from tabs
>  to spaces
> - remove interrupt-names property
> - remove obvious reg description
> - split long(>80) lines
> ---
>  Documentation/devicetree/bindings/mfd/maxim,max77705.yaml | 174 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>  MAINTAINERS                                               |   1 +
>  2 files changed, 175 insertions(+)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:

dtschema/dtc warnings/errors:
/builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/mfd/maxim,max77705.example.dtb: pmic@66: leds:compatible:0: 'maxim,max77705-rgb' was expected
	from schema $id: http://devicetree.org/schemas/mfd/maxim,max77705.yaml#
Documentation/devicetree/bindings/mfd/maxim,max77705.example.dtb: /example-0/i2c/pmic@66/leds: failed to match any schema with compatible: ['maxim,max77705-led']

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241023-starqltechn_integration_upstream-v7-2-9bfaa3f4a1a0@gmail.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.


  reply	other threads:[~2024-10-23 20:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-23 19:42 [PATCH v7 0/7] Add support for Maxim Integrated MAX77705 PMIC Dzmitry Sankouski
2024-10-23 19:42 ` [PATCH v7 1/7] power: supply: add undervoltage health status property Dzmitry Sankouski
2024-10-23 19:42 ` [PATCH v7 2/7] dt-bindings: mfd: add maxim,max77705 Dzmitry Sankouski
2024-10-23 20:35   ` Rob Herring (Arm) [this message]
2024-10-24  6:59   ` Krzysztof Kozlowski
2024-10-23 19:42 ` [PATCH v7 3/7] mfd: Add new driver for MAX77705 PMIC Dzmitry Sankouski
2024-10-26 13:17   ` kernel test robot
2024-10-23 19:42 ` [PATCH v7 4/7] input: max77693: add max77705 haptic support Dzmitry Sankouski
2024-10-23 19:42 ` [PATCH v7 5/7] power: supply: max77705: Add charger driver for Maxim 77705 Dzmitry Sankouski
2024-10-23 19:42 ` [PATCH v7 6/7] power: supply: max77705: Add fuel gauge " Dzmitry Sankouski
2024-10-23 19:42 ` [PATCH v7 7/7] leds: max77705: Add LEDs support Dzmitry Sankouski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=172971571004.1852226.15537632667573865513.robh@kernel.org \
    --to=robh@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=cw00.choi@samsung.com \
    --cc=devicetree@vger.kernel.org \
    --cc=dmitry.torokhov@gmail.com \
    --cc=dsankouski@gmail.com \
    --cc=krzk@kernel.org \
    --cc=lee@kernel.org \
    --cc=linux-input@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-leds@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).