From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>,
Biju Das <biju.das.jz@bp.renesas.com>
Cc: Support Opensource <support.opensource@diasemi.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
Prabhakar Mahadev Lad <prabhakar.mahadev-lad.rj@bp.renesas.com>,
"biju.das.au" <biju.das.au@gmail.com>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH 2/3] Input: da9063 - Use dev_err_probe()
Date: Thu, 14 Dec 2023 07:48:35 +1100 [thread overview]
Message-ID: <1784A867-E5BA-47BC-AC3C-5B5EAB2A056B@gmail.com> (raw)
In-Reply-To: <CAMuHMdV6sPuRp3=5T43Ruu2P3mMB5C5w4=QS_GVVxT8GuwRDpA@mail.gmail.com>
On December 12, 2023 8:28:45 PM GMT+11:00, Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>Hi Biju,
>
>On Tue, Dec 12, 2023 at 10:03 AM Biju Das <biju.das.jz@bp.renesas.com> wrote:
>> > From: Geert Uytterhoeven <geert@linux-m68k.org>
>> > On Mon, Dec 11, 2023 at 5:57 PM Biju Das <biju.das.jz@bp.renesas.com>
>> > wrote:
>> > > Replace dev_err()->dev_err_probe() to simpilfy probe().
>> > >
>> > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
>
>> OK, I will send
>>
>> 1) separate patch for dropping unneeded prints related to OOM
>> 2) A patch for replacing dev_err()->dev_err_probe() + Update error message for devm_request_threaded_irq()
>> 3) separate patch for dropping print message for input_register_device();
>>
>> Is it ok?
>
>Personally, I'd be fine with just a single "cleanup error printing" patch.
>But Dmitry has the final say.
I'm fine with a single patch unless you feel strongly about splitting it in 2.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2023-12-13 20:48 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-11 16:57 [PATCH 0/3] Add polling support for DA9063 onkey driver Biju Das
2023-12-11 16:57 ` [PATCH 1/3] Input: da9063 - Simplify obtaining OF match data Biju Das
2023-12-11 16:57 ` [PATCH 2/3] Input: da9063 - Use dev_err_probe() Biju Das
2023-12-11 19:05 ` Sergey Shtylyov
2023-12-11 19:07 ` Biju Das
2023-12-12 8:01 ` Geert Uytterhoeven
2023-12-12 9:03 ` Biju Das
2023-12-12 9:28 ` Geert Uytterhoeven
2023-12-13 20:48 ` Dmitry Torokhov [this message]
2023-12-13 21:09 ` Biju Das
2023-12-11 16:57 ` [PATCH 3/3] Input: da9063 - Add polling support Biju Das
2023-12-11 17:07 ` Biju Das
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1784A867-E5BA-47BC-AC3C-5B5EAB2A056B@gmail.com \
--to=dmitry.torokhov@gmail.com \
--cc=biju.das.au@gmail.com \
--cc=biju.das.jz@bp.renesas.com \
--cc=geert@linux-m68k.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
--cc=support.opensource@diasemi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox