From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f176.google.com (mail-oi1-f176.google.com [209.85.167.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 724C325E444 for ; Tue, 25 Feb 2025 06:30:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740465007; cv=none; b=QyCiEDO5jNnD7oy8uBw8+DjHQf3ipd7vb/lfcbB9m0BQjmFegoylS3bQqERaJtsxF2/eSv5bckqwq6uzixqIwYkLZ5f0/MeAg3W8x1M7X3XPQ9tGAKAZ5ZXaoZvei3y9RDcdZxQGg/TBky3Bc9MpJBu82EtnlFwXF1RYsTLv8Z8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1740465007; c=relaxed/simple; bh=RYfyD32sRASx29xi497H3XJdDF3XXVn40eOIf2rnFm0=; h=From:To:CC:Date:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=i2CSn7IoaqRkZs6NgXB30D1fTDv9nFt6aytQCVdP40jTtnrOy5Xrnaxv369CXzPQFi7iNbaR6SsFZYs9Du7c/oA7BTxbN2G27he5fMRCjVGtjZsuHKf0fEPWOPSj+ZdnG/qU7Jnb1kPUIqDEksKvawW6o1tH0s38E7lrZOM5SC0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com; spf=fail smtp.mailfrom=broadcom.com; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b=ATVTdfAo; arc=none smtp.client-ip=209.85.167.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=broadcom.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=broadcom.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="ATVTdfAo" Received: by mail-oi1-f176.google.com with SMTP id 5614622812f47-3f3eade4116so2262243b6e.0 for ; Mon, 24 Feb 2025 22:30:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1740465004; x=1741069804; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:subject:user-agent :references:in-reply-to:message-id:date:cc:to:from:from:to:cc :subject:date:message-id:reply-to; bh=4+mBAQq6Mkez/2/DMWHStf85qnBYyGFLVJqfvqnbkxk=; b=ATVTdfAoZ8/xxq1ZmnjF7OLKA0Xgvb7CoBQQ87W4nCqYvgoKGF1WfWw7itwOEF/kQ2 qSEC712GTgta39biH0N9ptdUCZON99uEGDNtQAHraF5yqKkiQif0P3PLLx4dOpd02hU3 w51m7o1mLP/kdvlplhEAUBZB0iorvyx/M6eRY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1740465004; x=1741069804; h=content-transfer-encoding:mime-version:subject:user-agent :references:in-reply-to:message-id:date:cc:to:from :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=4+mBAQq6Mkez/2/DMWHStf85qnBYyGFLVJqfvqnbkxk=; b=cgkfHnTnwJG66re/pPJtOziJNDcYOoTqehbdjLBVaQ2lk57wSAWgWg8R4vxQK3yoIq LtVuksgJKAkxyN3G3oRp4NsvnsR9NYkCSIZADKEioaMiLnSicmnDQgiqb0QUbaFzgtL+ AdMJrnum53z1uuE7XtP9Tntp8ANk0ErOrZguM1toeHyhyaVdEtHOyou/CizR2daEST8l 9VSiWydU0FLijoIfG9h9Y7dCWFomQyFvJ6el5Yqd6XjURUbyDsChzi9F+d8N+0p9OA3c gXyAAjdqZxs1pxO3jGpGgLA7GiZvJMv/mHoRkwRk7GT6rZfcLlyKMEzARBcwUmvU3NdE cyrA== X-Forwarded-Encrypted: i=1; AJvYcCXtls/KZDiZ7bP8np+EPFbCb1RcPXD9HJMW/ArisgACNv13wioUswgO4z+6ZQ3cxcWAs26/761XnPnsGw==@vger.kernel.org X-Gm-Message-State: AOJu0Yxxw63J+ULdP5hhUA1YafoQp7CITiUNnEyA3ixFLTse7SEG84KU HdyD7epH06aFtRAtzeeaf7TF7LBPCaFPCHYNjdTraDm69n+SmPL+ZW70RPL53g== X-Gm-Gg: ASbGncs7kPkA+DocJmwTOgpNkGgsyolPQ8pyfMKlo9eLa+GpuIhIsTlHTapnco1gCzD Df4egTgVi4fnyIfiJS1D8DgThMeL/T/Uj9vVaXchd6ftB0uqns2J8nD2s5Pl1i8OtklmjNJblbg fmiswMDoorSHa0B49ylY+/u2t0cAoB8Omg4xc9e+zX08kaqmw/nZxejbdmtEA98dRTQ3cCmIzAp m1dj1zODM6tt4CKmS8LLa1Sn6k7aoXrgiJLaeMPXggZFJdC/mHxBZ1enOgFN2dEtMDE0/Nf7XUU eVh1aZVYb6cHXGPWqCKW9N8KeLChsMvXVxqRdjfGmcZ/9WVNb95fi22JjDuNTG3V X-Google-Smtp-Source: AGHT+IFdXMbhGx7fP9GFKGlpguOITWaZZGOBzMRAt9OnDAJpr0Tf6LoZNYE9WcUj4WMJOinaxdWK7Q== X-Received: by 2002:a05:6808:3c8f:b0:3f3:e8e7:2001 with SMTP id 5614622812f47-3f424777eb0mr12305946b6e.26.1740465004283; Mon, 24 Feb 2025 22:30:04 -0800 (PST) Received: from [192.168.178.74] (f215227.upc-f.chello.nl. [80.56.215.227]) by smtp.gmail.com with ESMTPSA id 5614622812f47-3f541bd992bsm190300b6e.16.2025.02.24.22.29.49 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 24 Feb 2025 22:30:03 -0800 (PST) From: Arend Van Spriel To: "Kuan-Wei Chiu" , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , , CC: , , , , , , , , , , , , , , , , , , , , , "Yu-Chun Lin" Date: Tue, 25 Feb 2025 07:29:46 +0100 Message-ID: <1953bcc1790.279b.9b12b7fc0a3841636cfb5e919b41b954@broadcom.com> In-Reply-To: <20250223164217.2139331-12-visitorckw@gmail.com> References: <20250223164217.2139331-1-visitorckw@gmail.com> <20250223164217.2139331-12-visitorckw@gmail.com> User-Agent: AquaMail/1.54.1 (build: 105401536) Subject: Re: [PATCH 11/17] wifi: brcm80211: Replace open-coded parity calculation with parity32() Precedence: bulk X-Mailing-List: linux-input@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; format=flowed; charset="us-ascii" Content-Transfer-Encoding: 8bit On February 23, 2025 5:44:54 PM Kuan-Wei Chiu wrote: > Refactor parity calculations to use the standard parity32() helper. > This change eliminates redundant implementations and improves code > efficiency. While the dust settles on the exact implementation from driver perspective looks fine to me so... Acked-by: Arend van Spriel > > Co-developed-by: Yu-Chun Lin > Signed-off-by: Yu-Chun Lin > Signed-off-by: Kuan-Wei Chiu > --- > .../wireless/broadcom/brcm80211/brcmsmac/dma.c | 16 +--------------- > 1 file changed, 1 insertion(+), 15 deletions(-)