From: Randy Dunlap <rdunlap@infradead.org>
To: Manuel Ebner <manuelebnerli@mailbox.org>,
Henk Vergonet <Henk.Vergonet@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
Shuah Khan <skhan@linuxfoundation.org>
Cc: linux-input@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 20/32] Input: yealink.rst: Fix bracket
Date: Fri, 4 Sep 2026 14:11:35 -0700 [thread overview]
Message-ID: <1969e90f-1286-4ad7-9bbc-8f3800a44353@infradead.org> (raw)
In-Reply-To: <20260904121026.759218-3-manuelebnerli@mailbox.org>
On 9/4/26 5:10 AM, Manuel Ebner wrote:
> Remove needless '['.
>
> Signed-off-by: Manuel Ebner <manuelebnerli@mailbox.org>
> ---
> Documentation/input/devices/yealink.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/input/devices/yealink.rst b/Documentation/input/devices/yealink.rst
> index bb5a1aafe..de86cf7f5 100644
> --- a/Documentation/input/devices/yealink.rst
> +++ b/Documentation/input/devices/yealink.rst
> @@ -205,7 +205,7 @@ Troubleshooting
> :Q: Module yealink compiled and installed without any problem but phone
> is not initialized and does not react to any actions.
> :A: If you see something like:
> - hiddev0: USB HID v1.00 Device [Yealink Network Technology Ltd. VOIP USB Phone
> + hiddev0: USB HID v1.00 Device Yealink Network Technology Ltd. VOIP USB Phone
> in dmesg, it means that the hid driver has grabbed the device first. Try to
> load module yealink before any other usb hid driver. Please see the
> instructions provided by your distribution on module configuration.
According to drivers/hid/hid-core.c (near line 2395 in today's linux-next tree),
this documentation should have a ']' added to it:
hid_info(hdev, "%s: %s HID v%x.%02x %s [%s] on %s\n",
buf, bus, hdev->version >> 8, hdev->version & 0xff,
type, hdev->name, hdev->phys);
so
+ hiddev0: USB HID v1.00 Device [Yealink Network Technology Ltd. VOIP USB Phone]
AFAICT.
--
~Randy
prev parent reply other threads:[~2026-09-04 21:11 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 12:10 [PATCH 20/32] Input: yealink.rst: Fix bracket Manuel Ebner
2026-09-04 21:11 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1969e90f-1286-4ad7-9bbc-8f3800a44353@infradead.org \
--to=rdunlap@infradead.org \
--cc=Henk.Vergonet@gmail.com \
--cc=corbet@lwn.net \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manuelebnerli@mailbox.org \
--cc=skhan@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox