From: Alexander Stein <alexander.stein@systec-electronic.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
Alexandre Courbot <gnurou@gmail.com>,
Linux Input <linux-input@vger.kernel.org>
Subject: Re: gpio irqchip initialization race
Date: Fri, 01 Apr 2016 14:45:17 +0200 [thread overview]
Message-ID: <19734973.Q0xUTsGU7P@ws-stein> (raw)
In-Reply-To: <CACRpkdYeMdUtqizXGFzLDwbiL7=xDM+tt0kQU5S166AL13Y_1Q@mail.gmail.com>
On Friday 01 April 2016 13:29:14, Linus Walleij wrote:
> On Fri, Apr 1, 2016 at 10:56 AM, Alexander Stein
>
> <alexander.stein@systec-electronic.com> wrote:
> > [Me]
> >
> >> And in this case (if gpio_keys handle -EPROBE_DEFER gracefully)
> >> all should be fine with my oneliner patch.
> >>
> >> I am more uncertain about the -EINVAL (-22) we might need some
> >> more analysis there.
> >
> > I did 10 runs and got the following results:
> >> 3x gpio-keys user_sw: Unable to claim irq 0; error -22
> >> 2x gpio-keys user_sw: Unable to get irq number for GPIO 376, error -517
> >> 5x ok
> >
> > So, for one gpio-keys seems not to handle -EPROBE_DEFER gracefully
>
> After reading the code the only problem seems to be that it prints that
> error. A small patch to silence that print should fix it then, can you
> confirm that in these cases the gpio-keys are retried later?
Ah, yes. You're right. I just checked for the error messages, but not if the
device are actually absent. I just had a start where a (different) gpio-keys
device failed with error -517 but is available when loggin in. So it really is
just fix to silence on -DEFER_PROBE.
Best regards,
Alexander
prev parent reply other threads:[~2016-04-01 12:45 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <44236018.b6N0xPzKYW@ws-stein>
2016-04-01 8:43 ` gpio irqchip initialization race Linus Walleij
2016-04-01 8:47 ` Linus Walleij
2016-04-01 8:56 ` Alexander Stein
2016-04-01 11:29 ` Linus Walleij
2016-04-01 12:45 ` Alexander Stein [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=19734973.Q0xUTsGU7P@ws-stein \
--to=alexander.stein@systec-electronic.com \
--cc=dmitry.torokhov@gmail.com \
--cc=gnurou@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox