From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Kamel BOUHARA <kamel.bouhara@bootlin.com>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Henrik Rydberg <rydberg@bitmath.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Marco Felsch <m.felsch@pengutronix.de>,
Jeff LaBundy <jeff@labundy.com>,
catalin.popescu@leica-geosystems.com,
mark.satterthwaite@touchnetix.com, bartp@baasheep.co.uk,
hannah.rossiter@touchnetix.com,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Gregory Clement <gregory.clement@bootlin.com>,
bsp-development.geo@leica-geosystems.com
Subject: Re: [PATCH v4 2/3] dt-bindings: input: Add TouchNetix axiom touchscreen
Date: Tue, 5 Dec 2023 10:26:41 +0100 [thread overview]
Message-ID: <1a3ce8a9-a9f0-48fe-ac1b-aabbe58967a8@linaro.org> (raw)
In-Reply-To: <8ac4a9924e1d3b98c9f74dcb07b044b2@bootlin.com>
On 05/12/2023 10:17, Kamel BOUHARA wrote:
> Le 2023-12-05 09:15, Krzysztof Kozlowski a écrit :
>> On 04/12/2023 15:05, Kamel Bouhara wrote:
>>> Add the TouchNetix axiom I2C touchscreen device tree bindings
>>> documentation.
>>>
>>> Signed-off-by: Kamel Bouhara <kamel.bouhara@bootlin.com>
>>
>>> +$id:
>>> http://devicetree.org/schemas/input/touchscreen/touchnetix,ax54a.yaml#
>>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>>> +
>>> +title: TouchNetix Axiom series touchscreen controller
>>> +
>>> +maintainers:
>>> + - Kamel Bouhara <kamel.bouhara@bootlin.com>
>>> +
>>
>> Why you do not have ref to touchscreen? Is it not a touchscreen?
>
> The common properties are not used or applicable here, should I still
> ref touchscreen ?
Why they are not applicable? Do you get the panel coordinates and sizes
from device registers or are they fixed somehow in the controller?
...
>
>>> + description: I/O power supply regulator on VDDI pin
>>> +
>>> +required:
>>> + - compatible
>>> + - reg
>>
>> Supplies are usually required. Devices rarely can operate without
>> power.
>
> Indeed, can I still have them optional in the driver ?
Yes, I comment here only about the bindings. Bindings are not related to
your driver, but to hardware.
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-12-05 9:26 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-04 14:05 [PATCH v4 0/3] Input: Add TouchNetix axiom touchscreen driver Kamel Bouhara
2023-12-04 14:05 ` [PATCH v4 1/3] dt-bindings: vendor-prefixes: Add TouchNetix AS Kamel Bouhara
2023-12-04 14:05 ` [PATCH v4 2/3] dt-bindings: input: Add TouchNetix axiom touchscreen Kamel Bouhara
2023-12-05 8:15 ` Krzysztof Kozlowski
2023-12-05 9:17 ` Kamel BOUHARA
2023-12-05 9:26 ` Krzysztof Kozlowski [this message]
2023-12-04 14:05 ` [PATCH v4 3/3] Input: Add TouchNetix axiom i2c touchscreen driver Kamel Bouhara
2023-12-04 15:09 ` POPESCU Catalin
2023-12-04 16:16 ` Kamel Bouhara
2023-12-05 6:36 ` kernel test robot
2023-12-07 5:28 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a3ce8a9-a9f0-48fe-ac1b-aabbe58967a8@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=bartp@baasheep.co.uk \
--cc=bsp-development.geo@leica-geosystems.com \
--cc=catalin.popescu@leica-geosystems.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregory.clement@bootlin.com \
--cc=hannah.rossiter@touchnetix.com \
--cc=jeff@labundy.com \
--cc=kamel.bouhara@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m.felsch@pengutronix.de \
--cc=mark.satterthwaite@touchnetix.com \
--cc=robh+dt@kernel.org \
--cc=rydberg@bitmath.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).