From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82DF7C77B72 for ; Mon, 17 Apr 2023 19:21:00 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230012AbjDQTU7 (ORCPT ); Mon, 17 Apr 2023 15:20:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40150 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229568AbjDQTU6 (ORCPT ); Mon, 17 Apr 2023 15:20:58 -0400 Received: from bombadil.infradead.org (bombadil.infradead.org [IPv6:2607:7c80:54:3::133]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 948B046A1; Mon, 17 Apr 2023 12:20:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:Cc:To:Subject:MIME-Version:Date: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=OCXQAUqZq8AENPbfKo9BLSD0arsRH/iVJodv9zOemb0=; b=Op11VnBitQiV1BtUJzm1VFDJW6 BGGx6h4ClV44qMdsWj3v9yIy/Z0idVD0zuoZNipfygUawMoqf362gOfZqsBdgesL3sC9fsO7j9DPT 4rpUUJj/LeXf8amvlSy7XaNKEQ799lSF1Q1Q6nBa7dCnQR49aT2vPxHY31TEYBoHPARJgnGcJ8icf htuyGlxIAg3m0r0rByLOdtW8pbm94CkUBANiJb8SBx7VSDL3wv8PSTdVqIgjfquShhL3r5RxtO/gl qaMMA1G5dEZWFXqE8T9yRA3d42mZ0JUEsS+mH3cdlGLqWAhCYtwVMXWPs9SxHI+Uv3fD/NPKGaufU LF4EfGpQ==; Received: from [2601:1c2:980:9ec0::2764] by bombadil.infradead.org with esmtpsa (Exim 4.96 #2 (Red Hat Linux)) id 1poUPG-00HPUr-0s; Mon, 17 Apr 2023 19:20:54 +0000 Message-ID: <1a754a3e-2a2b-07d5-c94a-0373a1677e4e@infradead.org> Date: Mon, 17 Apr 2023 12:20:51 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0 Subject: Re: [PATCH v3 1/1] HID: shield: Initial driver implementation with Thunderstrike support Content-Language: en-US To: Rahul Rameshbabu , Jiri Kosina , Benjamin Tissoires Cc: linux-input@vger.kernel.org, linux-kernel@vger.kernel.org References: <20230417182909.33833-1-rrameshbabu@nvidia.com> <20230417182909.33833-2-rrameshbabu@nvidia.com> From: Randy Dunlap In-Reply-To: <20230417182909.33833-2-rrameshbabu@nvidia.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Hi, On 4/17/23 11:29, Rahul Rameshbabu wrote: > diff --git a/drivers/hid/Kconfig b/drivers/hid/Kconfig > index 82f64fb31fda..eb19debaa1f5 100644 > --- a/drivers/hid/Kconfig > +++ b/drivers/hid/Kconfig > @@ -990,6 +990,24 @@ config HID_SEMITEK > - Woo-dy > - X-Bows Nature/Knight > > +config HID_SHIELD > + tristate "SHIELD HID Driver" > + depends on USB_HID > + depends on BT_HIDP > + help > + Support for NVIDIA SHIELD accessories. > + > + Supported devices: > + - Thunderstrike (NVIDIA SHIELD Controller 2017) > + > +config SHIELD_FF > + bool "SHIELD force feedback support" > + depends on HID_SHIELD > + select INPUT_FF_MEMLESS > + help > + Say Y here if you would like to enable force feedback support for > + NVIDIA SHIELD accessories with haptics capabilities. According to Documentation/process/coding-style.rst, Kconfig help text should be indented by 2 spaces after the "help" line: 10) Kconfig configuration files ------------------------------- For all of the Kconfig* configuration files throughout the source tree, the indentation is somewhat different. Lines under a ``config`` definition are indented with one tab, while help text is indented an additional two spaces. Example:: config AUDIT bool "Auditing support" depends on NET help Enable auditing infrastructure that can be used with another kernel subsystem, such as SELinux (which requires this for logging of avc messages output). Does not do system-call auditing without CONFIG_AUDITSYSCALL. -- ~Randy