* [PATCH] HID: holtekff: move MODULE_* parameters out of #ifdef block
@ 2017-11-26 4:34 Daniel Axtens
2017-11-26 11:33 ` Anssi Hannula
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Daniel Axtens @ 2017-11-26 4:34 UTC (permalink / raw)
To: jikos, benjamin.tissoires, linux-input, anssi.hannula; +Cc: Daniel Axtens
If you compile with:
CONFIG_HID_HOLTEK=m
CONFIG_HOLTEK_FF is not set
You get the following warning:
WARNING: modpost: missing MODULE_LICENSE() in drivers/hid/hid-holtekff.o
see include/linux/module.h for more information
Fix this by moving the module info out of the #ifdef CONFIG_HOLTEK_FF
block and into the un-guarded part of the file.
Signed-off-by: Daniel Axtens <dja@axtens.net>
---
drivers/hid/hid-holtekff.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/hid/hid-holtekff.c b/drivers/hid/hid-holtekff.c
index 9325545fc3ae..edc0f64bb584 100644
--- a/drivers/hid/hid-holtekff.c
+++ b/drivers/hid/hid-holtekff.c
@@ -32,10 +32,6 @@
#ifdef CONFIG_HOLTEK_FF
-MODULE_LICENSE("GPL");
-MODULE_AUTHOR("Anssi Hannula <anssi.hannula@iki.fi>");
-MODULE_DESCRIPTION("Force feedback support for Holtek On Line Grip based devices");
-
/*
* These commands and parameters are currently known:
*
@@ -223,3 +219,7 @@ static struct hid_driver holtek_driver = {
.probe = holtek_probe,
};
module_hid_driver(holtek_driver);
+
+MODULE_LICENSE("GPL");
+MODULE_AUTHOR("Anssi Hannula <anssi.hannula@iki.fi>");
+MODULE_DESCRIPTION("Force feedback support for Holtek On Line Grip based devices");
--
2.11.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] HID: holtekff: move MODULE_* parameters out of #ifdef block
2017-11-26 4:34 [PATCH] HID: holtekff: move MODULE_* parameters out of #ifdef block Daniel Axtens
@ 2017-11-26 11:33 ` Anssi Hannula
2017-11-27 8:18 ` Benjamin Tissoires
2017-12-01 8:53 ` Jiri Kosina
2 siblings, 0 replies; 4+ messages in thread
From: Anssi Hannula @ 2017-11-26 11:33 UTC (permalink / raw)
To: Daniel Axtens; +Cc: benjamin.tissoires, linux-input, jikos
Hi,
Daniel Axtens kirjoitti 2017-11-26 06:34:
> If you compile with:
> CONFIG_HID_HOLTEK=m
> CONFIG_HOLTEK_FF is not set
>
> You get the following warning:
> WARNING: modpost: missing MODULE_LICENSE() in
> drivers/hid/hid-holtekff.o
> see include/linux/module.h for more information
>
> Fix this by moving the module info out of the #ifdef CONFIG_HOLTEK_FF
> block and into the un-guarded part of the file.
>
> Signed-off-by: Daniel Axtens <dja@axtens.net>
Thanks!
Acked-by: Anssi Hannula <anssi.hannula@iki.fi>
> ---
> drivers/hid/hid-holtekff.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/hid/hid-holtekff.c b/drivers/hid/hid-holtekff.c
> index 9325545fc3ae..edc0f64bb584 100644
> --- a/drivers/hid/hid-holtekff.c
> +++ b/drivers/hid/hid-holtekff.c
> @@ -32,10 +32,6 @@
>
> #ifdef CONFIG_HOLTEK_FF
>
> -MODULE_LICENSE("GPL");
> -MODULE_AUTHOR("Anssi Hannula <anssi.hannula@iki.fi>");
> -MODULE_DESCRIPTION("Force feedback support for Holtek On Line Grip
> based devices");
> -
> /*
> * These commands and parameters are currently known:
> *
> @@ -223,3 +219,7 @@ static struct hid_driver holtek_driver = {
> .probe = holtek_probe,
> };
> module_hid_driver(holtek_driver);
> +
> +MODULE_LICENSE("GPL");
> +MODULE_AUTHOR("Anssi Hannula <anssi.hannula@iki.fi>");
> +MODULE_DESCRIPTION("Force feedback support for Holtek On Line Grip
> based devices");
--
Anssi Hannula
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] HID: holtekff: move MODULE_* parameters out of #ifdef block
2017-11-26 4:34 [PATCH] HID: holtekff: move MODULE_* parameters out of #ifdef block Daniel Axtens
2017-11-26 11:33 ` Anssi Hannula
@ 2017-11-27 8:18 ` Benjamin Tissoires
2017-12-01 8:53 ` Jiri Kosina
2 siblings, 0 replies; 4+ messages in thread
From: Benjamin Tissoires @ 2017-11-27 8:18 UTC (permalink / raw)
To: Daniel Axtens; +Cc: jikos, linux-input, anssi.hannula
On Nov 26 2017 or thereabouts, Daniel Axtens wrote:
> If you compile with:
> CONFIG_HID_HOLTEK=m
> CONFIG_HOLTEK_FF is not set
>
> You get the following warning:
> WARNING: modpost: missing MODULE_LICENSE() in drivers/hid/hid-holtekff.o
> see include/linux/module.h for more information
>
> Fix this by moving the module info out of the #ifdef CONFIG_HOLTEK_FF
> block and into the un-guarded part of the file.
>
> Signed-off-by: Daniel Axtens <dja@axtens.net>
> ---
Reviewed-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
Cheers,
Benjamin
> drivers/hid/hid-holtekff.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/hid/hid-holtekff.c b/drivers/hid/hid-holtekff.c
> index 9325545fc3ae..edc0f64bb584 100644
> --- a/drivers/hid/hid-holtekff.c
> +++ b/drivers/hid/hid-holtekff.c
> @@ -32,10 +32,6 @@
>
> #ifdef CONFIG_HOLTEK_FF
>
> -MODULE_LICENSE("GPL");
> -MODULE_AUTHOR("Anssi Hannula <anssi.hannula@iki.fi>");
> -MODULE_DESCRIPTION("Force feedback support for Holtek On Line Grip based devices");
> -
> /*
> * These commands and parameters are currently known:
> *
> @@ -223,3 +219,7 @@ static struct hid_driver holtek_driver = {
> .probe = holtek_probe,
> };
> module_hid_driver(holtek_driver);
> +
> +MODULE_LICENSE("GPL");
> +MODULE_AUTHOR("Anssi Hannula <anssi.hannula@iki.fi>");
> +MODULE_DESCRIPTION("Force feedback support for Holtek On Line Grip based devices");
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] HID: holtekff: move MODULE_* parameters out of #ifdef block
2017-11-26 4:34 [PATCH] HID: holtekff: move MODULE_* parameters out of #ifdef block Daniel Axtens
2017-11-26 11:33 ` Anssi Hannula
2017-11-27 8:18 ` Benjamin Tissoires
@ 2017-12-01 8:53 ` Jiri Kosina
2 siblings, 0 replies; 4+ messages in thread
From: Jiri Kosina @ 2017-12-01 8:53 UTC (permalink / raw)
To: Daniel Axtens; +Cc: benjamin.tissoires, linux-input, anssi.hannula
On Sun, 26 Nov 2017, Daniel Axtens wrote:
> If you compile with:
> CONFIG_HID_HOLTEK=m
> CONFIG_HOLTEK_FF is not set
>
> You get the following warning:
> WARNING: modpost: missing MODULE_LICENSE() in drivers/hid/hid-holtekff.o
> see include/linux/module.h for more information
>
> Fix this by moving the module info out of the #ifdef CONFIG_HOLTEK_FF
> block and into the un-guarded part of the file.
>
> Signed-off-by: Daniel Axtens <dja@axtens.net>
Applied to for-4.15/upstream-fixes. Thanks,
--
Jiri Kosina
SUSE Labs
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-12-01 8:53 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-11-26 4:34 [PATCH] HID: holtekff: move MODULE_* parameters out of #ifdef block Daniel Axtens
2017-11-26 11:33 ` Anssi Hannula
2017-11-27 8:18 ` Benjamin Tissoires
2017-12-01 8:53 ` Jiri Kosina
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).