From: Benjamin Wheeler <benjaminwheeler0510@gmail.com>
To: Jiri Kosina <jikos@kernel.org>, Sriman Achanta <srimanachanta@gmail.com>
Cc: Benjamin Tissoires <bentiss@kernel.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
Bastien Nocera <hadess@hadess.net>,
Simon Wood <simon@mungewell.org>,
Christian Mayer <git@mayer-bgk.de>
Subject: Re: [PATCH v7 0/8] HID: steelseries: split out Arctis driver and add Nova 5X/Nova 7 support
Date: Tue, 4 Aug 2026 20:26:50 -0400 [thread overview]
Message-ID: <1d62c563-4ee3-4693-8f68-d464e5da57f4@gmail.com> (raw)
In-Reply-To: <p2ro1683-r1p3-80qs-q6s1-nr6p18ss03p8@xreary.bet>
I'm glad to hear this is getting merged! I have studied and tested older
revisions of Sriman's patchset on my Arctis 7 Gen2 and would love to
contribute a patch that adds support for it as well. I see you have a
branch called for-7.3/steelseries in the hid kernel fork. Should I base
my patchset off that? And should I aim to have this ready before the 7.3
merge window, or would 7.4 be more realistic? Thanks for the direction.
Sincerely,
Benjamin Wheeler
P.S. And thanks for working on this, Sriman!
On 8/3/26 3:32 PM, Jiri Kosina wrote:
> On Mon, 3 Aug 2026, Sriman Achanta wrote:
>
>> This series moves the SteelSeries Arctis headset support out of
>> hid-steelseries.c into its own module, reworks it around a per-model
>> device_info table, hardens the battery power-supply lifetime, adds an
>> asynchronous status interface, and finally adds support for the Arctis
>> Nova 5X and Nova 7 families. After the split, hid-steelseries.c is left
>> handling the SRW-S1 racing wheel and the MSI RGB LED devices.
>>
>> Changes since v6:
>> - Rebased onto hid.git#for-7.3/steelseries.
>> - The split now leaves the MSI RGB code in hid-steelseries.c
>> alongside SRW-S1, and strips only the headset members from
>> struct steelseries_device. The MSI RGB quirk bit is renumbered
>> to BIT(1) since the two Arctis bits are gone.
>> - The Arctis hardening that came with the MSI commit moves into
>> hid-steelseries-arctis.c with the rest of the headset code: the
>> hdev->rsize < 3 guard in steelseries_is_vendor_usage_page(), the
>> battery_registered store/load-acquire pair, the !sd checks, and
>> the hid_hw_stop() on the hid_hw_open() error path. The
>> steelseries_is_headset() dispatch is dropped, as the new module
>> only binds headsets. The battery_registered flag then goes away
>> in patch 3, where the device_info rework guards every
>> power_supply_changed() on sd->battery instead.
>> - The v6 patch "HID: steelseries: Inline and simplify SRWS1 wheel
>> driver" is dropped. Its premise was that hid-steelseries.c only
>> handles the SRW-S1 after the split, which is no longer true.
>> - No other changes. The resulting hid-steelseries-arctis.c is
>> byte-identical to v6.
> Thanks a lot for such a brisk rebase. Now queued.
>
prev parent reply other threads:[~2026-08-05 0:26 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-03 19:15 [PATCH v7 0/8] HID: steelseries: split out Arctis driver and add Nova 5X/Nova 7 support Sriman Achanta
2026-08-03 19:15 ` [PATCH v7 1/8] HID: steelseries: Fix ARCTIS_1_X device mislabeling Sriman Achanta
2026-08-03 19:15 ` [PATCH v7 2/8] HID: steelseries: Split Arctis headset driver into separate module Sriman Achanta
2026-08-03 19:15 ` [PATCH v7 3/8] HID: steelseries: Refactor Arctis driver to use device_info framework Sriman Achanta
2026-08-03 19:25 ` sashiko-bot
2026-08-03 19:15 ` [PATCH v7 4/8] HID: steelseries: Report POWER_SUPPLY_STATUS_FULL when full Sriman Achanta
2026-08-03 19:15 ` [PATCH v7 5/8] HID: steelseries: Correct Arctis 9 battery calibration range Sriman Achanta
2026-08-03 19:15 ` [PATCH v7 6/8] HID: steelseries: Manage battery lifetime with refcounting Sriman Achanta
2026-08-03 19:29 ` sashiko-bot
2026-08-03 19:15 ` [PATCH v7 7/8] HID: steelseries: Add async status interface support Sriman Achanta
2026-08-03 19:29 ` sashiko-bot
2026-08-03 19:15 ` [PATCH v7 8/8] HID: steelseries: Add support for Arctis Nova 5X and Nova 7 families Sriman Achanta
2026-08-03 19:32 ` [PATCH v7 0/8] HID: steelseries: split out Arctis driver and add Nova 5X/Nova 7 support Jiri Kosina
2026-08-05 0:26 ` Benjamin Wheeler [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1d62c563-4ee3-4693-8f68-d464e5da57f4@gmail.com \
--to=benjaminwheeler0510@gmail.com \
--cc=bentiss@kernel.org \
--cc=git@mayer-bgk.de \
--cc=hadess@hadess.net \
--cc=jikos@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=simon@mungewell.org \
--cc=srimanachanta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox