From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0B6CEC54FC9 for ; Tue, 21 Apr 2020 13:50:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DB73020672 for ; Tue, 21 Apr 2020 13:50:27 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="MmHn2l2r" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728479AbgDUNu1 (ORCPT ); Tue, 21 Apr 2020 09:50:27 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:49319 "EHLO us-smtp-1.mimecast.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726018AbgDUNu1 (ORCPT ); Tue, 21 Apr 2020 09:50:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1587477025; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fYUyqUrhhbqGF35kWuwwdWpfOqC+MMf8X1CRN78TKMk=; b=MmHn2l2rs8zUBIDrrxJJ2o3K88KnsWVd41JXy++GVBS4WIwZ7eodq8PoP+hbIiHdLghMxo qJ5tneSVV6KbtTO8GnysAaTjThn7ioqA2lgiC22eBor+2f++VggDlUMKL3U9QIpBT/ctfH dk3ycAfvP0N7H8JtV9pi6q49iDEIJPM= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-480-MKVlu4V4Oym7Kth73M4zJg-1; Tue, 21 Apr 2020 09:50:13 -0400 X-MC-Unique: MKVlu4V4Oym7Kth73M4zJg-1 Received: by mail-wm1-f71.google.com with SMTP id j5so1474054wmi.4 for ; Tue, 21 Apr 2020 06:50:13 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=fYUyqUrhhbqGF35kWuwwdWpfOqC+MMf8X1CRN78TKMk=; b=EFf5FY7VPB6wm6dHGmB9FhQx3kstKcjNbLE1al8GkQ7/pBo3yTKUtpwfofbB9k0VMA 0ycADS0jTinVWyITyxv6ONPVWhBHRZPI1LK+4SuSfbGhY4hGomZs9W6a7p6UHLGPYDPA +gZxescsjc05E5U5JmytdMzo+AsDLeIndL4OAw0d/phqwbNszem3q/j7/pAxheNtctmp 13baz07jDcXcZoyik3G9Off7MXNLOEnGSxD/J4Rsyiw6+H3xvq607c7fbLb7Eyxt8i4+ dFnMrh37F4lPHakyg89b/1CnJQVpat5q7Wc24JOr2zq65zPGc6KThuTnbpNGX8C0mFqf PYUQ== X-Gm-Message-State: AGi0PuZChrmI2FTes9eDwlzn2/Tx2utDNJIyx/cSV9uF5ulBDJyew8w4 gseh5bJtke3U9Dw+rKEOe2kaFfsVubbGWJxZtP+Tk47EaQX1num7r8F1DF/1QhTuQ+QfxlL10ms 70j+Ic2oCimDrfJqu43LHqB4= X-Received: by 2002:a7b:c181:: with SMTP id y1mr5339852wmi.83.1587477012394; Tue, 21 Apr 2020 06:50:12 -0700 (PDT) X-Google-Smtp-Source: APiQypJhXaIQkhcHPAdDUQbyLGGHq104La/5m2RWz1UDpxPs6mNMJOnsNeJfrKHfaYb95Gmj5PzIhw== X-Received: by 2002:a7b:c181:: with SMTP id y1mr5339838wmi.83.1587477012189; Tue, 21 Apr 2020 06:50:12 -0700 (PDT) Received: from x1.localdomain (2001-1c00-0c0c-fe00-d2ea-f29d-118b-24dc.cable.dynamic.v6.ziggo.nl. [2001:1c00:c0c:fe00:d2ea:f29d:118b:24dc]) by smtp.gmail.com with ESMTPSA id k6sm3889340wma.19.2020.04.21.06.50.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 21 Apr 2020 06:50:11 -0700 (PDT) Subject: Re: [PATCH] platform/x86: touchscreen_dmi: Add info for the ONDA V891 v5 tablet To: Maksim Karasev Cc: dvhart@infradead.org, andy@infradead.org, linux-input@vger.kernel.org, platform-driver-x86@vger.kernel.org References: <20200421132548.5627-1-karasevm98@gmail.com> From: Hans de Goede Message-ID: <1fd3919b-6094-9c33-64d0-e8775c4428bc@redhat.com> Date: Tue, 21 Apr 2020 15:50:10 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 MIME-Version: 1.0 In-Reply-To: <20200421132548.5627-1-karasevm98@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-input-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-input@vger.kernel.org Hi, On 4/21/20 3:25 PM, Maksim Karasev wrote: > Add touchscreen info for the ONDA V891 v5 tablet. Thank you for the patch. Can you please replace v891 with v891w everywhere to be consistent with the existing v891 entries; and ... > > Signed-off-by: Maksim Karasev > --- > drivers/platform/x86/touchscreen_dmi.c | 27 ++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/drivers/platform/x86/touchscreen_dmi.c b/drivers/platform/x86/touchscreen_dmi.c > index 6ec8923dec1a..cc2a2e0a0585 100644 > --- a/drivers/platform/x86/touchscreen_dmi.c > +++ b/drivers/platform/x86/touchscreen_dmi.c > @@ -448,6 +448,24 @@ static const struct ts_dmi_data onda_v820w_32g_data = { > .properties = onda_v820w_32g_props, > }; > > +static const struct property_entry onda_v891_v5_props[] = { > + PROPERTY_ENTRY_U32("touchscreen-size-x", 1715), > + PROPERTY_ENTRY_U32("touchscreen-size-y", 1140), > + PROPERTY_ENTRY_BOOL("touchscreen-inverted-x"), > + PROPERTY_ENTRY_BOOL("touchscreen-inverted-y"), > + PROPERTY_ENTRY_BOOL("touchscreen-swapped-x-y"), > + PROPERTY_ENTRY_STRING("firmware-name", > + "gsl3676-onda-v891-v5.fw"), > + PROPERTY_ENTRY_U32("silead,max-fingers", 10), > + PROPERTY_ENTRY_BOOL("silead,home-button"), > + { } > +}; > + > +static const struct ts_dmi_data onda_v891_v5_data = { > + .acpi_name = "MSSL1680:00", > + .properties = onda_v891_v5_props, > +}; > + Put this after the v891w_v3 entry please so that we have in order v1, v3 and then v5. Thanks, Hans > static const struct property_entry onda_v891w_v1_props[] = { > PROPERTY_ENTRY_U32("touchscreen-min-x", 46), > PROPERTY_ENTRY_U32("touchscreen-min-y", 8), > @@ -940,6 +958,15 @@ const struct dmi_system_id touchscreen_dmi_table[] = { > DMI_EXACT_MATCH(DMI_PRODUCT_NAME, "V820w DualOS") > }, > }, > + { > + /* ONDA V891 v5 */ > + .driver_data = (void *)&onda_v891_v5_data, > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "ONDA"), > + DMI_MATCH(DMI_PRODUCT_NAME, "ONDA Tablet"), > + DMI_MATCH(DMI_BIOS_VERSION, "ONDA.D869CJABNRBA06"), > + }, > + }, > { > /* ONDA V891w revision P891WBEBV1B00 aka v1 */ > .driver_data = (void *)&onda_v891w_v1_data, >