From: Pete Zaitcev <zaitcev@redhat.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-kernel@vger.kernel.org,
linux-input@atrey.karlin.mff.cuni.cz, zaitcev@redhat.com
Subject: Re: Fix locking in mousedev
Date: Fri, 9 Mar 2007 10:36:56 -0800 [thread overview]
Message-ID: <20070309103656.cd681677.zaitcev@redhat.com> (raw)
In-Reply-To: <d120d5000703090628p46556d52qb94b523fda4e947d@mail.gmail.com>
On Fri, 9 Mar 2007 09:28:49 -0500, "Dmitry Torokhov" <dmitry.torokhov@gmail.com> wrote:
> On 2/28/07, Pete Zaitcev <zaitcev@redhat.com> wrote:
> > Dmitry, please consider getting rid of the list of handles entirely.
> > The other major user is drivers/char/keyboard.c.
>
> I agree that handlers should not access h_list nad use their own
> private lists instead. However input core still needs that list to
> maintain its books.
Hmm. So it appears that my patch wastes 2 ulongs per input handle
then, in the name of preventing oopses. OK.
> I agree with the patch, unfortunately in lands squarely in the middle
> of me restructuring the code (swiitch to struct device, proper
> refcounting, etc) but I will try to adopt it.
Don't worry about this too much, I can always retest and resubmit,
as long as the main idea is agreeable to you. My users are on RHEL.
Therefore, my main concern is to get something into your tree in
order to avoid this regressing in the future. Meanwhile, users of
our 2.6.9 and 2.6.18 forks get a version of this patch.
-- Pete
next prev parent reply other threads:[~2007-03-09 18:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-28 19:06 Fix locking in mousedev Pete Zaitcev
2007-03-09 14:28 ` Dmitry Torokhov
2007-03-09 18:36 ` Pete Zaitcev [this message]
2007-03-09 20:54 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070309103656.cd681677.zaitcev@redhat.com \
--to=zaitcev@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).