linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Dmitry Torokhov <dtor@insightbb.com>
To: Pete Zaitcev <zaitcev@redhat.com>
Cc: linux-kernel@vger.kernel.org, linux-input@atrey.karlin.mff.cuni.cz
Subject: Re: Fix sudden warps in mousedev
Date: Sun, 25 Mar 2007 01:34:02 -0400	[thread overview]
Message-ID: <200703250134.03416.dtor@insightbb.com> (raw)
In-Reply-To: <20070324001610.724a820a.zaitcev@redhat.com>

Hi Pete,

On Saturday 24 March 2007 03:16, Pete Zaitcev wrote:
> -       } else if (!mousedev->touch)
> +       } else if (!mousedev->touch) {
>                 mousedev->touch = jiffies;
> +               /*
> +                * Seed the ring with new position where finger has just landed.
> +                *
> +                * Without this, a touchpad may report an unchanged position,
> +                * then a sync. The input_event() eats the position report, but
> +                * lets the sync through. We increment pkt_count and leave 
> +                * a stale position in the ring. If a future reference to fx(2)
> +                * hits the stale position, a large dx is reported, and the
> +                * pointer warps across the screen.
> +                */
> +               dev = mousedev->handle.dev;
> +               fx(0) = dev->abs[ABS_X];
> +               fy(0) = dev->abs[ABS_Y];
> 

I do not like input hanlders poking into input devices... Can't we just
reset pkt_count at the beginning of the touch to get rid of stale data?

-- 
Dmitry

  reply	other threads:[~2007-03-25  5:34 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-03-24  7:16 Fix sudden warps in mousedev Pete Zaitcev
2007-03-25  5:34 ` Dmitry Torokhov [this message]
2007-03-25 18:19   ` Pete Zaitcev
2007-03-26  3:19     ` Dmitry Torokhov
2007-03-26 19:17       ` Pete Zaitcev
2007-03-26 19:30         ` Dmitry Torokhov
2007-03-26 21:42           ` Pete Zaitcev
2007-03-27  1:14             ` Dmitry Torokhov
2007-03-27 15:14               ` Chuck Ebbert
2007-03-27 15:46                 ` Dmitry Torokhov
2007-03-27 16:04                   ` Chuck Ebbert
2007-03-27 16:19                     ` Dmitry Torokhov
2007-03-28 20:51                       ` Matt Keenan
2007-04-11 21:51               ` Peter Osterlund

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200703250134.03416.dtor@insightbb.com \
    --to=dtor@insightbb.com \
    --cc=linux-input@atrey.karlin.mff.cuni.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zaitcev@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).