linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* Re: [PATCH] don't invert mightymouse hwheel
@ 2007-04-13  0:32 Barton C Massey
  0 siblings, 0 replies; 19+ messages in thread
From: Barton C Massey @ 2007-04-13  0:32 UTC (permalink / raw)
  To: Barton C Massey
  Cc: linux-input, Antonio-M. Corbi Bellot, Johannes Berg, Jiri Kosina

--------
I wrote:

> 	Section "InputDevice"
> 	  Identifier  "MouseMightyMouse0"
> 	  Driver      "mouse"
> 	  Option      "Device" "/dev/input/mouse1"
> 	  Option      "Dev Name" "Mitsumi Electric Apple Optical USB Mouse"
> 	EndSection

Oops---thinko.  The config I'm actually using is

  Section "InputDevice"
    Identifier  "EvMightyMouse0"
    Driver "evdev"
    Option "Name" "Mitsumi Electric Apple Optical USB Mouse"
  EndSection

Sorry for the confusion.

	Bart

^ permalink raw reply	[flat|nested] 19+ messages in thread
* Re: [PATCH] don't invert mightymouse hwheel
@ 2007-04-13  0:21 Barton C Massey
  2007-04-13  6:45 ` Johannes Berg
                   ` (4 more replies)
  0 siblings, 5 replies; 19+ messages in thread
From: Barton C Massey @ 2007-04-13  0:21 UTC (permalink / raw)
  Cc: linux-input, Antonio-M. Corbi Bellot, Johannes Berg, Jiri Kosina

--------
> In message <Pine.LNX.4.64.0704121800000.19492@jikos.suse.cz> I wrote:
> > On Thu, 12 Apr 2007, Johannes Berg wrote:
> > 
> > > This is not true. With this X configuration:
> > > 
> > >     Section "InputDevice"
> > >         Identifier  "EvDev"
> > >         Driver      "evdev"
> > >         Option      "SendCoreEvents"    "true"
> > >         Option      "evBits"            "+1-2"
> > >         Option      "keyBits"           "~272-287"
> > >         Option      "relBits"           "~0-2 ~6 ~8"
> > >         Option      "Pass"              "3"
> > >     EndSection
> > > I can scroll up in a window by moving my finger up, and scroll left in a
> > > window by moving my finger right. That makes no sense, this patch therefore
> > > removes the INVERT_HWHEEL quirk from the USB mightymouse.
> > 
> > I unfortunately don't have the hardware in question to test with. This X 
> > configuration is of course perfectly valid.
> > 
> > Bart, as you wrote the original patch which inverted the wheel, could you 
> > provide some more information please? It seems to me that you guys have 
> > different versions of mightymouse ... but I wouldn't believe they would 
> > have the same PID :)
> 
> Give me a day or so to check all this out.  I don't think
> looking at the X behavior is too useful: too many places that
> the direction can be swapped.  Instead, look which way the
> bits coming directly out of evdev point.  IIRC I set things
> up so that positive X was the same as on other evdev
> devices.  Is the supplied X config swapping the X axis with
> this line?
> 
>   > >         Option      "evBits"            "+1-2"
> 
> One possible source of confusion is that Iceweasel scrolls
> backward by default (on all devices, not just MM).  You can
> fix this by changing a setting in the Iceweasel config.

After checking further I've found that my memory is correct.
With the patch as I originally submitted it (including the
INVERT_HWHEEL quirk):

  1) Moving the scroll ball to the right sends positive
     deltas (to /dev/input/event*), and moving it to the
     left sends negative deltas.  This is the same as the
     mouse itself, of course.

  2) You can use an xorg.conf entry as simple as

	Section "InputDevice"
	  Identifier  "MouseMightyMouse0"
	  Driver      "mouse"
	  Option      "Device" "/dev/input/mouse1"
	  Option      "Dev Name" "Mitsumi Electric Apple Optical USB Mouse"
	EndSection
				
  3) X SW (other than Iceweasel, which has the misfeature
     described earlier) just works properly.

Please don't remove the axis flip on the MM; it seems like
something most folks, including me, are quite happy with.
Instead, I'd suggest to Johannes that simplifying his X
config and/or fixing his Iceweasel config will straighten
his situation out.  (Most of that config is unnecessary at
best anyhow; I got all the button remaps right in my
original patch.)

These results are for the USB MM.  I have a Bluetooth MM
now, and am trying to find time to get it working also.
Sorry I haven't had time to do that yet.  Soon, honest.

    Bart Massey
    Assoc. Prof. Computer Science
    Portland State University
    bart@cs.pdx.edu

^ permalink raw reply	[flat|nested] 19+ messages in thread
* [PATCH] don't invert mightymouse hwheel
@ 2007-04-11 22:23 Johannes Berg
  2007-04-12 16:04 ` Jiri Kosina
  2007-04-12 21:25 ` Barton C Massey
  0 siblings, 2 replies; 19+ messages in thread
From: Johannes Berg @ 2007-04-11 22:23 UTC (permalink / raw)
  To: linux-input; +Cc: Antonio-M. Corbi Bellot, Jiri Kosina, Bart Massey

Commit a82e49b8aeb9f8dafdf6cf2e617c8b95bf056257 said:

    Further, the quirks for the Apple Mighty Mouse are not quite right: the
    horizontal scrolling needs its axis reversed, and the left and center
    buttons are transposed.

This is not true. With this X configuration:

    Section "InputDevice"
        Identifier  "EvDev"
        Driver      "evdev"
        Option      "SendCoreEvents"    "true"
        Option      "evBits"            "+1-2"
        Option      "keyBits"           "~272-287"
        Option      "relBits"           "~0-2 ~6 ~8"
        Option      "Pass"              "3"
    EndSection

I can scroll up in a window by moving my finger up, and scroll left in a
window by moving my finger right. That makes no sense, this patch therefore
removes the INVERT_HWHEEL quirk from the USB mightymouse.

I didn't change the bluetooth mightymouse, maybe it has this quirk after
all. My USB one definitely doesn't. If the bluetooth version doesn't have
that quirk either, we can completely remove the INVERT_HWHEEL quirk.

Signed-off-by: Johannes Berg <johannes@sipsolutions.net>
Cc: Jiri Kosina <jkosina@suse.cz>
Cc: Bart Massey <bart@cs.pdx.edu>
Cc: Antonio-M. Corbi Bellot <antonio.corbi@ua.es>

---
 drivers/usb/input/hid-core.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- wireless-dev.orig/drivers/usb/input/hid-core.c	2007-04-12 00:09:17.754507072 +0200
+++ wireless-dev/drivers/usb/input/hid-core.c	2007-04-12 00:09:25.334507072 +0200
@@ -898,7 +898,7 @@ static const struct hid_blacklist {
 	{ USB_VENDOR_ID_WISEGROUP, USB_DEVICE_ID_DUAL_USB_JOYPAD, HID_QUIRK_NOGET | HID_QUIRK_MULTI_INPUT },
 	{ USB_VENDOR_ID_WISEGROUP_LTD, USB_DEVICE_ID_SMARTJOY_DUAL_PLUS, HID_QUIRK_NOGET | HID_QUIRK_MULTI_INPUT },
 
-	{ USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_MIGHTYMOUSE, HID_QUIRK_MIGHTYMOUSE | HID_QUIRK_INVERT_HWHEEL },
+	{ USB_VENDOR_ID_APPLE, USB_DEVICE_ID_APPLE_MIGHTYMOUSE, HID_QUIRK_MIGHTYMOUSE },
 	{ USB_VENDOR_ID_A4TECH, USB_DEVICE_ID_A4TECH_WCP32PU, HID_QUIRK_2WHEEL_MOUSE_HACK_7 },
 	{ USB_VENDOR_ID_CYPRESS, USB_DEVICE_ID_CYPRESS_MOUSE, HID_QUIRK_2WHEEL_MOUSE_HACK_5 },
 

^ permalink raw reply	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2007-04-26 18:35 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-04-13  0:32 [PATCH] don't invert mightymouse hwheel Barton C Massey
  -- strict thread matches above, loose matches on Subject: below --
2007-04-13  0:21 Barton C Massey
2007-04-13  6:45 ` Johannes Berg
2007-04-13  7:43 ` Jiri Kosina
2007-04-13  9:30 ` Johannes Berg
2007-04-23 10:27 ` Barton C Massey
2007-04-23 13:13   ` Jiri Kosina
2007-04-23 13:43     ` Johannes Berg
2007-04-23 14:07       ` Jiri Kosina
2007-04-23 14:13         ` Johannes Berg
2007-04-26  8:24 ` Johannes Berg
2007-04-11 22:23 Johannes Berg
2007-04-12 16:04 ` Jiri Kosina
2007-04-12 21:25 ` Barton C Massey
2007-04-13  6:40   ` Johannes Berg
2007-04-25 20:06     ` Zephaniah E. Hull
2007-04-25 23:09     ` Barton C Massey
2007-04-26  0:00       ` Zephaniah E. Hull
2007-04-26 18:35       ` Barton C Massey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).