linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Carlos Corbacho <cathectic@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@atrey.karlin.mff.cuni.cz
Subject: Re: [PATCH] input: Add wireless and bluetooth keycodes
Date: Thu, 3 May 2007 13:18:59 +0100	[thread overview]
Message-ID: <200705031318.59817.cathectic@gmail.com> (raw)
In-Reply-To: <d120d5000705030458m7909bc5enc2ff6621f542c7cf@mail.gmail.com>

Dimitry,

On Thursday 03 May 2007 12:58:45 Dmitry Torokhov wrote:
> Already have them:
>
> #define KEY_BLUETOOTH           237
> #define KEY_WLAN                238

My bad.

> > Also, add keycodes for these
> > keys having a separate off state (This is true on some machines,
> > such as many Acer laptops).
>
> Not sure why this is needed.

On my laptop (this also affects other Acer's), the real problem is that there 
is no way to tell if the device is enabled or disabled[1], unless you're 
keeping track of this yourself (not always reliable). The only thing that 
always changes is the scancode for the button in question.

It would be nice to have a separate keycode to match to the different 
scancodes for on and off (then match these to the relevant calls), rather 
than say for instance, mapping both wireless scancodes to KEY_WLAN, then 
trying to keep track of the current state and then deciding on this whether 
to disable the device in question (and then potentially deciding wrong).

-Carlos

[1] The wireless/ bluetooth features on some Acer laptops are software 
enabled, by ACPI methods calling a Windows Management Instrumentation 
device - and to add insult to injury, the WMI interface provided doesn't give 
us any means to find out the current state of these features.
-- 
Uni: c.corbacho@cs.ucl.ac.uk
Home: cathectic@gmail.com
GPG Key ID: 0x23EE722D

      reply	other threads:[~2007-05-03 12:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-05-03 11:15 [PATCH] input: Add wireless and bluetooth keycodes Carlos Corbacho
2007-05-03 11:58 ` Dmitry Torokhov
2007-05-03 12:18   ` Carlos Corbacho [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200705031318.59817.cathectic@gmail.com \
    --to=cathectic@gmail.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@atrey.karlin.mff.cuni.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).