linux-input.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Aristeu Rozanski <arozansk@redhat.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: linux-input@atrey.karlin.mff.cuni.cz, Chris Williams <cww@redhat.com>
Subject: [PATCH] psmouse: add support for 4th button using the 4th bit
Date: Wed, 9 May 2007 10:53:37 -0400	[thread overview]
Message-ID: <20070509145337.GD4215@redhat.com> (raw)
In-Reply-To: <d120d5000705090736p145b6a7cn8645eccdb5c35ca3@mail.gmail.com>

Cortron PS/2 Trackballs (700-0001A) reports the 4th button using the 4th
bit of the first packet (yes, it breaks the protocol). This patch adds
an extra protocol to generate BTN_SIDE based on the 4th bit. There's no
way to detect those trackballs using any kind of special sequence, thus
the protocol is only available if selected writing 'protocol' file in
sysfs, e.g.:
	echo -n "cortps" >/sys/devices/platform/i8042/serio1/protocol

Signed-off-by: Aristeu Rozanski <arozansk@redhat.com>

--- linus-2.6.orig/drivers/input/mouse/psmouse-base.c
+++ linus-2.6/drivers/input/mouse/psmouse-base.c
@@ -177,6 +177,15 @@ static psmouse_ret_t psmouse_process_byt
 	}
 
 /*
+ * Cortron PS2 Trackball reports SIDE button on the 4th bit of the first
+ * byte.
+ */
+	if (psmouse->type == PSMOUSE_CORTRON) {
+		input_report_key(dev, BTN_SIDE, (packet[0] >> 3) & 1);
+		packet[0] |= 0x08;
+	}
+
+/*
  * Generic PS/2 Mouse
  */
 
@@ -538,6 +547,20 @@ static int ps2bare_detect(struct psmouse
 	return 0;
 }
 
+/*
+ * Cortron PS/2 protocol detection. There's no special way to detect it, so it
+ * must be forced by sysfs protocol writing.
+ */
+static int cortron_detect(struct psmouse *psmouse, int set_properties)
+{
+	if (set_properties) {
+		psmouse->vendor = "Cortron";
+		psmouse->name = "PS/2 Trackball";
+		set_bit(BTN_SIDE, psmouse->dev->keybit);
+	}
+
+	return 0;
+}
 
 /*
  * psmouse_extensions() probes for any extensions to the basic PS/2 protocol
@@ -655,6 +678,12 @@ static const struct psmouse_protocol psm
 		.detect		= ps2bare_detect,
 	},
 	{
+		.type		= PSMOUSE_CORTRON,
+		.name		= "CortronPS/2",
+		.alias		= "cortps",
+		.detect		= cortron_detect,
+	},
+	{
 		.type		= PSMOUSE_PS2PP,
 		.name		= "PS2++",
 		.alias		= "logitech",
--- linus-2.6.orig/drivers/input/mouse/psmouse.h
+++ linus-2.6/drivers/input/mouse/psmouse.h
@@ -78,6 +78,7 @@ struct psmouse {
 enum psmouse_type {
 	PSMOUSE_NONE,
 	PSMOUSE_PS2,
+	PSMOUSE_CORTRON,
 	PSMOUSE_PS2PP,
 	PSMOUSE_THINKPS,
 	PSMOUSE_GENPS,

  reply	other threads:[~2007-05-09 14:53 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-04-02 20:48 [RFC] psmouse: add support for 4th button using the 4th bit Aristeu Rozanski
2007-04-03 14:39 ` Dmitry Torokhov
2007-04-03 14:42   ` Aristeu Rozanski
2007-04-03 15:05     ` Dmitry Torokhov
2007-04-03 15:23       ` Aristeu Rozanski
2007-05-08 18:53       ` Aristeu Rozanski
2007-05-09 14:36         ` Dmitry Torokhov
2007-05-09 14:53           ` Aristeu Rozanski [this message]
2007-05-09 15:39             ` [PATCH] " Dmitry Torokhov
2007-05-09 15:49               ` Aristeu Rozanski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20070509145337.GD4215@redhat.com \
    --to=arozansk@redhat.com \
    --cc=cww@redhat.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-input@atrey.karlin.mff.cuni.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).