From mboxrd@z Thu Jan 1 00:00:00 1970 From: Pete Zaitcev Subject: Re: [PATCH] Make appletouch shut up when it has nothing to say Date: Sun, 13 May 2007 18:58:07 -0700 Message-ID: <20070513185807.18222a0d.zaitcev@redhat.com> References: <1178995886.4168.10.camel@localhost> <20070513172052.GA26712@srcf.ucam.org> <20070513114626.d943999a.zaitcev@redhat.com> <20070513195724.GA28493@srcf.ucam.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20070513195724.GA28493@srcf.ucam.org> Sender: owner-linux-input@atrey.karlin.mff.cuni.cz List-Help: List-Owner: List-Post: List-Unsubscribe: To: Matthew Garrett Cc: Soeren Sonnenburg , linux-input@atrey.karlin.mff.cuni.cz, nicolas@boichat.ch, linux-usb-devel@lists.sourceforge.net, Linux Kernel , zaitcev@redhat.com List-Id: linux-input@vger.kernel.org On Sun, 13 May 2007 20:57:25 +0100, Matthew Garrett wrote: > Ok, I've tidied this up a little. [...] Looks fine here... well, almost. Did you try rmmod (I don't even know if it's applicable, sorry)? Usually, when schedule_work is involved, you want to make sure that a scheduled work won't be run when the module is gone. More often, a device removal is the issue, but as I take it, such is not possible for a built-in device :-) . In most cases, all it takes is a strategically placed flush_scheduled_work(). -- Pete