From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: [PATCH] ACPI: thinkpad-acpi: add thinkpad keys to input.h Date: Wed, 30 May 2007 15:04:51 +0100 Message-ID: <20070530140450.GA29514@srcf.ucam.org> References: <11802004861625-git-send-email-hmh@hmh.eng.br> <200705262340.28219.dtor@insightbb.com> <20070527121513.GC19562@khazad-dum.debian.net> <200705282316.32173.dtor@insightbb.com> <20070529130528.GB12935@khazad-dum.debian.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: owner-linux-input@atrey.karlin.mff.cuni.cz List-Help: List-Owner: List-Post: List-Unsubscribe: To: Dmitry Torokhov Cc: Henrique de Moraes Holschuh , ibm-acpi-devel@lists.sourceforge.net, Richard Hughes , linux-acpi@vger.kernel.org, linux-input@atrey.karlin.mff.cuni.cz List-Id: linux-input@vger.kernel.org On Wed, May 30, 2007 at 09:57:11AM -0400, Dmitry Torokhov wrote: > I really don't like KEY_FN_F1..KEY_FN_BACKSPACE either. What are they > supposed to do? Just being an unique value to be mapped onto something > useful? But why not use that useful keycode to begin with? We've already got KEY_PROG* - is this not the sort of situation they're for? (ie, keys that aren't mapped to a specific purpose but would be potentially useful to userspace at the per-user level) > I'd rather leave the keys unmapped and rely on initsripts (possibly > with help from distributions vendors) to load proper keymap then add > something that must be retranslated over and over again. Changing the keymap is a privileged operation, so sending /some/ sort of keycode by default would probably be good. > Well, what kind of functions you would like them to have? You, as a > maintainer, can chose defaults. Since you (well, not you, the driver) > provide a way for a user to adjust keymap there should be no problem > even if someone does not like the values you chose. Having sensible > defaults is a good thing, otherwise many people will not even know > that they have these "separate" keys. Some of the Thinkpad keys send events even without there being any label, so I don't think there's a sane default other than leaving it up to the user. On the other hand, I'm not especially keen on sending literals like "FN_BACKSPACE" - it's hugely special-cased. -- Matthew Garrett | mjg59@srcf.ucam.org