From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: [PATCH] ACPI: thinkpad-acpi: add thinkpad keys to input.h Date: Wed, 30 May 2007 15:42:08 +0100 Message-ID: <20070530144208.GA30351@srcf.ucam.org> References: <11802004861625-git-send-email-hmh@hmh.eng.br> <200705262340.28219.dtor@insightbb.com> <20070527121513.GC19562@khazad-dum.debian.net> <200705282316.32173.dtor@insightbb.com> <20070529130528.GB12935@khazad-dum.debian.net> <20070530140450.GA29514@srcf.ucam.org> <20070530142516.GA30009@srcf.ucam.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: owner-linux-input@atrey.karlin.mff.cuni.cz List-Help: List-Owner: List-Post: List-Unsubscribe: To: Dmitry Torokhov Cc: Henrique de Moraes Holschuh , ibm-acpi-devel@lists.sourceforge.net, Richard Hughes , linux-acpi@vger.kernel.org, linux-input@atrey.karlin.mff.cuni.cz List-Id: linux-input@vger.kernel.org On Wed, May 30, 2007 at 10:31:35AM -0400, Dmitry Torokhov wrote: > Not all world is X :) Actually few of "FN" keys, like KEY_WLAN, > KEY_SLEEP, etc should be handled not [only] by X but by other layers. I agree - the ones that have a defined function should certainly be set to sensible defaults, but I think the sensible default for a key without a defined function is "Key of undefined function" (like KEY_PROG*), not "Key which doesn't generate a keycode" :) -- Matthew Garrett | mjg59@srcf.ucam.org