From: Brian Magnuson <bdmagnuson@gmail.com>
To: Jan Kratochvil <honza@jikos.cz>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-input@atrey.karlin.mff.cuni.cz
Subject: Re: [PATCH 3/4] xpad.c - support for xbox360 wireless receiver
Date: Sun, 3 Jun 2007 11:53:30 -0400 [thread overview]
Message-ID: <20070603155330.GB14913@rcn.com> (raw)
In-Reply-To: <20070603153723.GA14913@rcn.com>
* Brian Magnuson <bdmagnuson@gmail.com> [2007-06-03 11:37]:
> * Jan Kratochvil <honza@jikos.cz> [2007-06-03 11:18]:
> > Hi,
> > this one is tricky because I can't test it.
> > Brian, there is something I don't understand in your previous patch
> > concerning this issue. What is reported data length for wireless receiver
> > when it is sending its status report? I thought you are trying to ignore
> > packets about headset connection. But it is not working the same way for
> > wired device. In data[1] is actual length of packet (20).
> > Please test this patch (and the previous 2).
> > Thanks
>
> I can tell you without even testing that it's not going to work. The data
> length returned by the wireless controller is alway 29 bytes, but as far
> as I can tell there is no field that indicates that length.
Ok, looks like I was a bit hasty. Looking at the data again there does
appear to be a length field in the returned data however.
1) It's 19 bytes rather than 20. This is a internel data format length
though. The USB data returned is still 29 bytes long.
2) You still need to apply to four byte shift for it to be in the "right"
place.
-Brian
next prev parent reply other threads:[~2007-06-03 15:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-06-03 14:10 [PATCH 3/4] xpad.c - support for xbox360 wireless receiver Jan Kratochvil
2007-06-03 15:37 ` Brian Magnuson
2007-06-03 15:53 ` Brian Magnuson [this message]
2007-06-03 16:23 ` Jan Kratochvil
[not found] ` <bafd4ab0706031003n23c30e1ah3fdf82bf0e586aa8@mail.gmail.com>
2007-06-03 17:03 ` Fwd: " Brian Magnuson
2007-06-03 17:54 ` Jan Kratochvil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070603155330.GB14913@rcn.com \
--to=bdmagnuson@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=honza@jikos.cz \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox