* [PATCH] [trivial] drivers/input/joystick/grip_mp.c: ARRAY_SIZE
@ 2007-06-06 20:10 Andi Drebes
0 siblings, 0 replies; only message in thread
From: Andi Drebes @ 2007-06-06 20:10 UTC (permalink / raw)
To: dmitry.torokhov, linux-joystick, linux-input, kernel-janitors
This patch replaces an array size calculation in drivers/input/joystick/grip_mp.c
that was done using sizeof with the ARRAY_SIZE macro. To be more specific,
I replaced a variable called seq_len in the function dig_mode_start that stored
the size of the array with ARRAY_SIZE. The variable was referenced only once,
so I think removing it is ok.
Tested by compilation on an i386 box using "allyesconfig".
Diffed against Linus' git-tree.
Signed-off-by: Andi Drebes <lists-receive@programmierforen.de>
---
diff --git a/drivers/input/joystick/grip_mp.c b/drivers/input/joystick/grip_mp.c
index 555319e..4ed3a3e 100644
--- a/drivers/input/joystick/grip_mp.c
+++ b/drivers/input/joystick/grip_mp.c
@@ -320,10 +320,10 @@ static int multiport_io(struct gameport* gameport, int sendflags, int sendcode,
static int dig_mode_start(struct gameport *gameport, u32 *packet)
{
- int i, seq_len = sizeof(init_seq)/sizeof(int);
+ int i;
int flags, tries = 0, bads = 0;
- for (i = 0; i < seq_len; i++) { /* Send magic sequence */
+ for (i = 0; i < ARRAY_SIZE(init_seq); i++) { /* Send magic sequence */
if (init_seq[i])
gameport_trigger(gameport);
udelay(GRIP_INIT_DELAY);
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2007-06-06 20:10 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-06-06 20:10 [PATCH] [trivial] drivers/input/joystick/grip_mp.c: ARRAY_SIZE Andi Drebes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).