From: Jason Uhlenkott <jasonuhl@jasonuhl.org>
To: Stephen Hemminger <shemminger@linux-foundation.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Len Brown <lenb@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-input@atrey.karlin.mff.cuni.cz,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fujtisu application panel driver
Date: Wed, 4 Jul 2007 18:29:29 -0700 [thread overview]
Message-ID: <20070705012929.GA4728@aurum.uhlenkott.net> (raw)
In-Reply-To: <20070702111724.43ee5b43@freepuppy.localdomain.hemminger.net>
On Mon, Jul 02, 2007 at 11:17:24 -0700, Stephen Hemminger wrote:
> +static int __init apanel_init(void)
> +{
> + void __iomem *bios;
> + u8 devno;
> + int found = 0;
> +
> + if (!dmi_check_system(apanel_dmi_table)) {
> + printk(KERN_WARNING "apanel: DMI information does not match\n");
> + if (!force)
> + return -ENODEV;
> + }
> + BUG_ON(!keymap);
If force=1 and there's no DMI match, we're guaranteed to pop this BUG_ON.
> +
> + device_chip[devno] = (enum apanel_chip) chip;
> + ++found;
> + }
> + }
> + iounmap(bios);
This isn't the address we got from ioremap (although it happens to
work, since iounmap internally masks it against PAGE_MASK).
next prev parent reply other threads:[~2007-07-05 1:29 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-02 18:17 [PATCH] fujtisu application panel driver Stephen Hemminger
2007-07-02 19:16 ` Dmitry Torokhov
2007-09-03 8:58 ` Stephen Hemminger
2007-09-07 12:02 ` Pavel Machek
2007-09-12 11:38 ` [PATCH] Fujitsu application panel driver (rev3) Stephen Hemminger
2007-09-14 5:30 ` Dmitry Torokhov
2007-09-16 19:55 ` Stephen Hemminger
2007-09-16 20:22 ` Dmitry Torokhov
2007-10-23 19:55 ` [PATCH] Fujitsu application panel driver Stephen Hemminger
2007-10-24 23:03 ` Andrew Morton
2007-10-25 20:19 ` [PATCH] apanel: space savings Stephen Hemminger
2007-10-28 5:30 ` [PATCH] Fujitsu application panel driver Dmitry Torokhov
2007-11-18 22:36 ` Robert Gerlach
2007-11-19 4:43 ` Stephen Hemminger
2007-11-19 12:50 ` Robert Gerlach
2007-11-19 17:26 ` Stephen Hemminger
2007-11-19 20:37 ` Robert Gerlach
2007-11-19 23:19 ` Stephen Hemminger
2007-12-19 9:04 ` Robert Gerlach
2007-12-12 14:10 ` Dmitry Torokhov
2007-12-12 22:21 ` [PATCH] Fujitsu application panel led value Stephen Hemminger
2007-07-05 1:29 ` Jason Uhlenkott [this message]
2007-09-03 9:00 ` [PATCH] fujtisu application panel driver Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070705012929.GA4728@aurum.uhlenkott.net \
--to=jasonuhl@jasonuhl.org \
--cc=akpm@linux-foundation.org \
--cc=dmitry.torokhov@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=shemminger@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).