From: Dmitry Torokhov <dtor@insightbb.com>
To: Jeff Garzik <jeff@garzik.org>
Cc: linux-input@atrey.karlin.mff.cuni.cz, linux-kernel@vger.kernel.org
Subject: Re: [RFC/RFT 1/5] Input: implement proper locking in input core
Date: Tue, 24 Jul 2007 01:52:45 -0400 [thread overview]
Message-ID: <200707240152.47006.dtor@insightbb.com> (raw)
In-Reply-To: <46A58FBA.5010505@garzik.org>
Hi Jeff,
On Tuesday 24 July 2007 01:35, Jeff Garzik wrote:
>
> spin_lock_irq() should generally be avoided.
>
> In cases like the first case -- input_repeat_key() -- you are making
> incorrect assumptions about the state of interrupts. The other cases
> are probably ok, but in general spin_lock_irq() has a long history of
> being very fragile and quite often wrong.
>
> Use spin_lock_irqsave() to be safe. Definitely in input_repeat_key(),
> but I strongly recommend removing spin_lock_irq() from all your patches
> here.
>
Thasnk you for looking at the patches. Actually I went back and forth
between spin_lock_irq and spin_lock_irqsave.. I will change back to
irqsave version, it is indeed safer.
--
Dmitry
next prev parent reply other threads:[~2007-07-24 5:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-24 4:45 [RFC/RFT 0/5] Input locking patches Dmitry Torokhov
2007-07-24 4:45 ` [RFC/RFT 1/5] Input: implement proper locking in input core Dmitry Torokhov
2007-07-24 5:35 ` Jeff Garzik
2007-07-24 5:52 ` Dmitry Torokhov [this message]
2007-07-27 23:28 ` Indan Zupancic
2007-07-29 3:50 ` Dmitry Torokhov
2007-07-29 12:50 ` Indan Zupancic
2007-07-24 4:45 ` [RFC/RFT 2/5] evdev - implement proper locking Dmitry Torokhov
2007-07-24 4:45 ` [RFC/RFT 3/5] Input: tsdev " Dmitry Torokhov
2007-07-24 4:45 ` [RFC/RFT 4/5] Input: mousedev " Dmitry Torokhov
2007-07-24 4:45 ` [RFC/RFT 5/5] Input: joydev " Dmitry Torokhov
2007-07-27 22:25 ` [RFC/RFT 0/5] Input locking patches Indan Zupancic
2007-07-29 3:38 ` Dmitry Torokhov
2007-07-29 12:15 ` Indan Zupancic
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200707240152.47006.dtor@insightbb.com \
--to=dtor@insightbb.com \
--cc=jeff@garzik.org \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).