From: Len Brown <lenb@kernel.org>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Zhang Rui <rui.zhang@intel.com>,
linux-acpi@vger.kernel.org, linux-input@atrey.karlin.mff.cuni.cz,
mjg59@srcf.ucam.org, hmh@hmh.eng.hr, hughsient@gmail.com,
luming.yu@intel.com
Subject: Re: [PATCH V3 1/3] ACPI video hotkey: add new input key code for ACPI video hotkey events
Date: Thu, 23 Aug 2007 21:49:08 -0400 [thread overview]
Message-ID: <200708232149.09015.lenb@kernel.org> (raw)
In-Reply-To: <20070823212200.GA17191@khazad-dum.debian.net>
On Thursday 23 August 2007 17:22, Henrique de Moraes Holschuh wrote:
> On Thu, 23 Aug 2007, Dmitry Torokhov wrote:
> > On 8/23/07, Len Brown <lenb@kernel.org> wrote:
> > > Thanks for the refreshed patch series, Rui.
> > > I've added it to acpi-test.
> > >
> > > Still waiting on an ACK from Dmitry on the input.h definitions.
> >
> > Sorry, I am still trying to recover from a hard drive failure...
> >
> > The keycodes conflict with a pending patch adding KEY_BRL_DOT9 and
> > KEY_BRL_DOT10 and so have to be moved somewhere else.
>
> Also, this one:
> +#define KEY_DISPLAY_CYCLE 0x1f9
>
> Should probably be
> #define KEY_DISPLAY_CYCLE KEY_SWITCHVIDEOMODE
>
> According to what was explained to us (thinkpad-acpi and the other laptop
> hotkey drivers).
I agree. I noticed this also
and I'll send a refreshed patch shortly.
thanks,
-Len
next prev parent reply other threads:[~2007-08-24 1:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-20 10:23 [PATCH V3 1/3] ACPI video hotkey: add new input key code for ACPI video hotkey events Zhang Rui
2007-08-23 1:14 ` Len Brown
2007-08-23 19:32 ` Len Brown
2007-08-23 20:10 ` Dmitry Torokhov
2007-08-23 21:22 ` Henrique de Moraes Holschuh
2007-08-24 1:49 ` Len Brown [this message]
2007-08-24 4:10 ` Len Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708232149.09015.lenb@kernel.org \
--to=lenb@kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=hmh@hmh.eng.br \
--cc=hmh@hmh.eng.hr \
--cc=hughsient@gmail.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=luming.yu@intel.com \
--cc=mjg59@srcf.ucam.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).