* [2.6 patch] make the dummy touchkit_ps2_detect() static
@ 2007-08-14 21:22 Adrian Bunk
2007-08-30 5:11 ` Dmitry Torokhov
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2007-08-14 21:22 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: linux-input, linux-kernel
The dummy touchkit_ps2_detect() for the CONFIG_MOUSE_PS2_TOUCHKIT=n case
shouldn't be a global function.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
64d15c53e66b200d832a6009aa24c344883bcbcf
diff --git a/drivers/input/mouse/touchkit_ps2.h b/drivers/input/mouse/touchkit_ps2.h
index 61e9dfd..8a0dd35 100644
--- a/drivers/input/mouse/touchkit_ps2.h
+++ b/drivers/input/mouse/touchkit_ps2.h
@@ -15,7 +15,8 @@
#ifdef CONFIG_MOUSE_PS2_TOUCHKIT
int touchkit_ps2_detect(struct psmouse *psmouse, int set_properties);
#else
-inline int touchkit_ps2_detect(struct psmouse *psmouse, int set_properties)
+static inline int touchkit_ps2_detect(struct psmouse *psmouse,
+ int set_properties)
{
return -ENOSYS;
}
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [2.6 patch] make the dummy touchkit_ps2_detect() static
@ 2007-08-27 21:28 Adrian Bunk
0 siblings, 0 replies; 3+ messages in thread
From: Adrian Bunk @ 2007-08-27 21:28 UTC (permalink / raw)
To: Andrew Morton; +Cc: dmitry.torokhov, linux-input, linux-kernel
The dummy touchkit_ps2_detect() for the CONFIG_MOUSE_PS2_TOUCHKIT=n case
shouldn't be a global function.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
This patch has been sent on:
- 14 Aug 2007
--- a/drivers/input/mouse/touchkit_ps2.h
+++ b/drivers/input/mouse/touchkit_ps2.h
@@ -15,7 +15,8 @@
#ifdef CONFIG_MOUSE_PS2_TOUCHKIT
int touchkit_ps2_detect(struct psmouse *psmouse, int set_properties);
#else
-inline int touchkit_ps2_detect(struct psmouse *psmouse, int set_properties)
+static inline int touchkit_ps2_detect(struct psmouse *psmouse,
+ int set_properties)
{
return -ENOSYS;
}
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [2.6 patch] make the dummy touchkit_ps2_detect() static
2007-08-14 21:22 [2.6 patch] make the dummy touchkit_ps2_detect() static Adrian Bunk
@ 2007-08-30 5:11 ` Dmitry Torokhov
0 siblings, 0 replies; 3+ messages in thread
From: Dmitry Torokhov @ 2007-08-30 5:11 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-input, linux-kernel
Hi Adrian,
On Tuesday 14 August 2007 17:22, Adrian Bunk wrote:
> The dummy touchkit_ps2_detect() for the CONFIG_MOUSE_PS2_TOUCHKIT=n case
> shouldn't be a global function.
>
Applied, thank you.
Btw, sorry for the long silence - I had a hard drive crash and the day
after I restored everything the disk controller decided to die as well
and write garbage all over the new disk ;(
--
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-08-30 5:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-14 21:22 [2.6 patch] make the dummy touchkit_ps2_detect() static Adrian Bunk
2007-08-30 5:11 ` Dmitry Torokhov
-- strict thread matches above, loose matches on Subject: below --
2007-08-27 21:28 Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).