From: Jesper Juhl <jesper.juhl@gmail.com>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Vojtech Pavlik <vojtech@ucw.cz>,
Johann Deneux <johann.deneux@gmail.com>,
dtor@mail.ru, linux-input@atrey.karlin.mff.cuni.cz,
linux-joystick@atrey.karlin.mff.cuni.cz,
Jesper Juhl <jesper.juhl@gmail.com>
Subject: [PATCH] input: Silence 'unused variable' warning in iforce joystick driver
Date: Fri, 31 Aug 2007 00:13:12 +0200 [thread overview]
Message-ID: <200708310013.12347.jesper.juhl@gmail.com> (raw)
In the iforce driver we currently get this warning
drivers/input/joystick/iforce/iforce-packets.c: In function 'iforce_get_id_packet':
drivers/input/joystick/iforce/iforce-packets.c:249: warning: unused variable 'status'
if CONFIG_JOYSTICK_IFORCE_USB is not defined.
The warning is easy to avoid by simply moving the variable inside
the only case in the switch that actually use it.
Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---
diff --git a/drivers/input/joystick/iforce/iforce-packets.c b/drivers/input/joystick/iforce/iforce-packets.c
index 3154ccd..48d4a86 100644
--- a/drivers/input/joystick/iforce/iforce-packets.c
+++ b/drivers/input/joystick/iforce/iforce-packets.c
@@ -246,13 +246,12 @@ void iforce_process_packet(struct iforce *iforce, u16 cmd, unsigned char *data)
int iforce_get_id_packet(struct iforce *iforce, char *packet)
{
- int status;
-
switch (iforce->bus) {
case IFORCE_USB:
-
#ifdef CONFIG_JOYSTICK_IFORCE_USB
+ int status;
+
iforce->cr.bRequest = packet[0];
iforce->ctrl->dev = iforce->usbdev;
next reply other threads:[~2007-08-30 22:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-30 22:13 Jesper Juhl [this message]
2007-08-30 22:57 ` [PATCH] input: Silence 'unused variable' warning in iforce joystick driver Satyam Sharma
2007-08-30 22:50 ` Jesper Juhl
2007-08-31 15:26 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200708310013.12347.jesper.juhl@gmail.com \
--to=jesper.juhl@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dtor@mail.ru \
--cc=johann.deneux@gmail.com \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-joystick@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=vojtech@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).