From: Dmitry Torokhov <dtor@insightbb.com>
To: "Toralf Förster" <toralf.foerster@gmx.de>
Cc: linux-input@atrey.karlin.mff.cuni.cz
Subject: Re: build #315 failed for 2.6.23-rc6-gd017464 in linux/./drivers/input/joystick/xpad.c
Date: Tue, 18 Sep 2007 01:13:18 -0400 [thread overview]
Message-ID: <200709180113.19085.dtor@insightbb.com> (raw)
In-Reply-To: <200709161846.37585.toralf.foerster@gmx.de>
Hi Toralf,
On Sunday 16 September 2007 12:46, Toralf Förster wrote:
> Hello,
>
> the build with the attached .config failed, make ends with:
> ...
> CC arch/i386/lib/strstr.o
> CC arch/i386/lib/usercopy.o
> AR arch/i386/lib/lib.a
> GEN .version
> CHK include/linux/compile.h
> UPD include/linux/compile.h
> CC init/version.o
> LD init/built-in.o
> LD .tmp_vmlinux1
> drivers/built-in.o: In function `xpad_disconnect':
> xpad.c:(.text+0x18ba72): undefined reference to `led_classdev_unregister'
> drivers/built-in.o: In function `xpad_probe':
> xpad.c:(.text+0x18c565): undefined reference to `led_classdev_register'
> make: *** [.tmp_vmlinux1] Error 1
>
Thank you for the report. I believe the patch below should fix the problem.
--
Dmitry
Subject: Input: xpad - fix dependancy on LEDS class
Input: xpad - fix dependancy on LEDS class
The driver can not be built-in when LEDS class is a module.
Signed-off-by: Dmitry Torokhov <dtor@mail.ru>
---
drivers/input/joystick/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: linux/drivers/input/joystick/Kconfig
===================================================================
--- linux.orig/drivers/input/joystick/Kconfig
+++ linux/drivers/input/joystick/Kconfig
@@ -277,7 +277,7 @@ config JOYSTICK_XPAD_FF
config JOYSTICK_XPAD_LEDS
bool "LED Support for Xbox360 controller 'BigX' LED"
- depends on LEDS_CLASS && JOYSTICK_XPAD
+ depends on JOYSTICK_XPAD && (LED_CLASS=y || LED_CLASS=JOYSTICK_XPAD)
---help---
This option enables support for the LED which surrounds the Big X on
XBox 360 controller.
parent reply other threads:[~2007-09-18 5:13 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <200709161846.37585.toralf.foerster@gmx.de>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200709180113.19085.dtor@insightbb.com \
--to=dtor@insightbb.com \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=toralf.foerster@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).