From: aherrman@arcor.de
To: Len Brown <lenb@kernel.org>
Cc: Len Brown <len.brown@intel.com>,
Mattia Dongili <malattia@linux.it>,
Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
linux-acpi@vger.kernel.org, linux-input@atrey.karlin.mff.cuni.cz
Subject: Re: [PATCH] sony-laptop/thinkpad-acpi: fix build error
Date: Tue, 18 Sep 2007 21:53:31 +0200 [thread overview]
Message-ID: <20070918195331.GA5279@devil> (raw)
In-Reply-To: <200709181249.14909.lenb@kernel.org>
On Tue, Sep 18, 2007 at 12:49:14PM -0400, Len Brown wrote:
>
> I'd prefer to use "depends on" here, as "select" is sort
> of a last resort, given its inherent disfunctionalty
> (is that a word?:-)
Yes, select is evil as it does not take care of "select" and
"depends on" statements of the selected config option.
> yes, I wish "select" worked the way programmers want it to,
> but it doesn't. Indeed, the only reason using it here is technically
> correct is that both these invocations depends on X86 and that
> avoids the conflict with !s390 INPUT.
Hmm, wasn't especially aware of that.
> Also, the reality is that all configs that want these drivers
> will have INPUT set already -- something that probably could
> not be said of BACKLIGHT_CLASS_DEVICE etc. -- so this patch
> is really just to please randconfig.
Right you are. Randconfig found that one.
> Unless you object, I'll just change this to "depends on" when i apply it.
No, I don't object.
Regards,
Andreas
next prev parent reply other threads:[~2007-09-18 19:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20070917205434.GA22458@devil>
2007-09-18 16:49 ` [PATCH] sony-laptop/thinkpad-acpi: fix build error Len Brown
2007-09-18 19:23 ` Henrique de Moraes Holschuh
2007-09-18 19:53 ` aherrman [this message]
2007-09-18 23:04 ` Mattia Dongili
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070918195331.GA5279@devil \
--to=aherrman@arcor.de \
--cc=hmh@hmh.eng.br \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=malattia@linux.it \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).