Re: [PATCH] sony-laptop/thinkpad-acpi: fix build error

Re: [PATCH] sony-laptop/thinkpad-acpi: fix build error

[Len Brown]

On Monday 17 September 2007 16:54, Andreas Herrmann wrote:
> sony-laptop and thinkpad-acpi make use of input-core functions.
> Hence you get link errors if those drivers are built but CONFIG_INPUT
> is not set. Attached patch fixes this minor issue.
> 
> 
> Regards,
> 
> Andreas
> 
> --
> Build errors if CONFIG_SONY_LAPTOP && !INPUT or
> if CONFIG_THINKPAD_ACPI && !INPUT:
> 
>  LD      vmlinux
>     ...
> drivers/built-in.o: In function `sony_laptop_remove_input':
> sony-laptop.c:(.text+0x768fb): undefined reference to `input_unregister_device'
>     ...
> drivers/built-in.o: In function `thinkpad_acpi_module_exit':
> thinkpad_acpi.c:(.text+0x78c1b): undefined reference to `input_free_device'
>     ...
> 
> I suggest to auto-select CONFIG_INPUT for both drivers.


I'd prefer to use "depends on" here, as "select" is sort
of a last resort, given its inherent disfunctionalty
(is that a word?:-)

yes, I wish "select" worked the way programmers want it to,
but it doesn't.  Indeed, the only reason using it here is technically
correct is that both these invocations depends on X86 and that
avoids the conflict with !s390 INPUT.

Also, the reality is that all configs that want these drivers
will have INPUT set already -- something that probably could
not be said of BACKLIGHT_CLASS_DEVICE etc. -- so this patch
is really just to please randconfig.

Unless you object, I'll just change this to "depends on" when i apply it.

thanks,
-Len


> Signed-off-by: Andreas Herrmann <aherrman@arcor.de>
> ---
>  drivers/misc/Kconfig |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/misc/Kconfig b/drivers/misc/Kconfig
> index 73e248f..c077df8 100644
> --- a/drivers/misc/Kconfig
> +++ b/drivers/misc/Kconfig
> @@ -134,6 +134,7 @@ config SONY_LAPTOP
>  	tristate "Sony Laptop Extras"
>  	depends on X86 && ACPI
>  	select BACKLIGHT_CLASS_DEVICE
> +	select INPUT
>  	  ---help---
>  	  This mini-driver drives the SNC and SPIC devices present in the ACPI
>  	  BIOS of the Sony Vaio laptops.
> @@ -156,6 +157,7 @@ config THINKPAD_ACPI
>  	select BACKLIGHT_CLASS_DEVICE
>  	select HWMON
>  	select NVRAM
> +	select INPUT
>  	---help---
>  	  This is a driver for the IBM and Lenovo ThinkPad laptops. It adds
>  	  support for Fn-Fx key combinations, Bluetooth control, video

Re: [PATCH] sony-laptop/thinkpad-acpi: fix build error

[Henrique de Moraes Holschuh]

On Tue, 18 Sep 2007, Len Brown wrote:
> Unless you object, I'll just change this to "depends on" when i apply it.

IMHO either is fine, so consider this an Ack for either select or depend for
what concerns thinkpad-acpi.

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

Re: [PATCH] sony-laptop/thinkpad-acpi: fix build error

[aherrman]

On Tue, Sep 18, 2007 at 12:49:14PM -0400, Len Brown wrote:
> 
> I'd prefer to use "depends on" here, as "select" is sort
> of a last resort, given its inherent disfunctionalty
> (is that a word?:-)

Yes, select is evil as it does not take care of "select" and
"depends on" statements of the selected config option.

> yes, I wish "select" worked the way programmers want it to,
> but it doesn't.  Indeed, the only reason using it here is technically
> correct is that both these invocations depends on X86 and that
> avoids the conflict with !s390 INPUT.

Hmm, wasn't especially aware of that.

> Also, the reality is that all configs that want these drivers
> will have INPUT set already -- something that probably could
> not be said of BACKLIGHT_CLASS_DEVICE etc. -- so this patch
> is really just to please randconfig.

Right you are. Randconfig found that one.

> Unless you object, I'll just change this to "depends on" when i apply it.

No, I don't object.


Regards,

Andreas

Re: [PATCH] sony-laptop/thinkpad-acpi: fix build error

[Mattia Dongili]

On Tue, Sep 18, 2007 at 12:49:14PM -0400, Len Brown wrote:
> On Monday 17 September 2007 16:54, Andreas Herrmann wrote:
> > sony-laptop and thinkpad-acpi make use of input-core functions.
> > Hence you get link errors if those drivers are built but CONFIG_INPUT
> > is not set. Attached patch fixes this minor issue.
...
> Unless you object, I'll just change this to "depends on" when i apply it.

that is fine to me

cheers
-- 
mattia
:wq!