From: Matthew Garrett <mjg59@srcf.ucam.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Thomas Rohwer <tr@tng.de>,
linux-input@atrey.karlin.mff.cuni.cz,
Soeren Sonnenburg <kernel@nn7.de>
Subject: Re: Problem with appletouch driver in Linux version 2.6.23-rc7
Date: Mon, 24 Sep 2007 13:49:31 +0100 [thread overview]
Message-ID: <20070924124931.GA22649@srcf.ucam.org> (raw)
In-Reply-To: <d120d5000709240540ic91832em277a6bcbb399cd45@mail.gmail.com>
On Mon, Sep 24, 2007 at 08:40:56AM -0400, Dmitry Torokhov wrote:
> On 9/22/07, Thomas Rohwer <tr@tng.de> wrote:
> > I tried Linux version 2.6.23-rc7 on my macbook pro using the appletouch input driver.
> > I noticed that often release events for the touchpad button are missing. This does not
> > occur with Linux version 2.6.22. I suppose this is related to the new reset logic in
> > the driver introduced in 2.6.23. If a reset occurs while the button is pressed the
> > release event seems to be not sent sometimes. The attached patch fixes the problem for me. It
> > changes the count towards idle so that the count is only incremented if the touchpad
> > button is not pressed. I also attached the output of lsusb.txt.
I'd spotted this, but hadn't got around to fixing it yet. Thanks for
picking it up!
> I will fix these up myself, you don't need to resubmit the patch. I
> only need "Signed-off-by: ... " line from you. Thanks!
Acked-by: Matthew Garrett <mjg59@srcf.ucam.org>
--
Matthew Garrett | mjg59@srcf.ucam.org
next prev parent reply other threads:[~2007-09-24 12:49 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-22 17:14 Problem with appletouch driver in Linux version 2.6.23-rc7 Thomas Rohwer
2007-09-24 12:40 ` Dmitry Torokhov
2007-09-24 12:49 ` Matthew Garrett [this message]
2007-09-24 13:03 ` Soeren Sonnenburg
2007-09-24 13:22 ` Thomas Rohwer
2007-09-26 19:56 ` Soeren Sonnenburg
2007-09-26 20:13 ` Dmitry Torokhov
2007-09-27 17:51 ` Soeren Sonnenburg
2007-09-27 21:08 ` Thomas Rohwer
2007-10-13 21:33 ` Soeren Sonnenburg
2007-10-13 21:44 ` Matthew Garrett
2007-10-15 13:09 ` Dmitry Torokhov
2007-09-24 13:10 ` Thomas Rohwer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070924124931.GA22649@srcf.ucam.org \
--to=mjg59@srcf.ucam.org \
--cc=dmitry.torokhov@gmail.com \
--cc=kernel@nn7.de \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=tr@tng.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).