From mboxrd@z Thu Jan 1 00:00:00 1970 From: Matthew Garrett Subject: Re: Problem with appletouch driver in Linux version 2.6.23-rc7 Date: Mon, 24 Sep 2007 13:49:31 +0100 Message-ID: <20070924124931.GA22649@srcf.ucam.org> References: <46F54D92.7000300@tng.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: Sender: owner-linux-input@atrey.karlin.mff.cuni.cz List-Help: List-Owner: List-Post: List-Unsubscribe: To: Dmitry Torokhov Cc: Thomas Rohwer , linux-input@atrey.karlin.mff.cuni.cz, Soeren Sonnenburg List-Id: linux-input@vger.kernel.org On Mon, Sep 24, 2007 at 08:40:56AM -0400, Dmitry Torokhov wrote: > On 9/22/07, Thomas Rohwer wrote: > > I tried Linux version 2.6.23-rc7 on my macbook pro using the appletouch input driver. > > I noticed that often release events for the touchpad button are missing. This does not > > occur with Linux version 2.6.22. I suppose this is related to the new reset logic in > > the driver introduced in 2.6.23. If a reset occurs while the button is pressed the > > release event seems to be not sent sometimes. The attached patch fixes the problem for me. It > > changes the count towards idle so that the count is only incremented if the touchpad > > button is not pressed. I also attached the output of lsusb.txt. I'd spotted this, but hadn't got around to fixing it yet. Thanks for picking it up! > I will fix these up myself, you don't need to resubmit the patch. I > only need "Signed-off-by: ... " line from you. Thanks! Acked-by: Matthew Garrett -- Matthew Garrett | mjg59@srcf.ucam.org