From: Oliver Neukum <oliver@neukum.org>
To: Jiri Kosina <jikos@jikos.cz>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
linux-usb-devel@lists.sourceforge.net,
linux-input@atrey.karlin.mff.cuni.cz,
Alan Stern <stern@rowland.harvard.edu>
Subject: Re: even newer version of USB HID autosuspend
Date: Sat, 6 Oct 2007 11:15:53 +0200 [thread overview]
Message-ID: <200710061115.53986.oliver@neukum.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0710051827040.25413@twin.jikos.cz>
Am Freitag 05 Oktober 2007 schrieb Jiri Kosina:
> On Fri, 5 Oct 2007, Oliver Neukum wrote:
>
> > Please review and/or test.
>
> Hi Oliver,
>
> thanks a lot for taking care of this, I will look at it and give it some
> testing ASAP.
>
> I am still surprised how large this patch has to be ...
So was I.
1. The input layer insists on doing output from interrupt
2. HID has very elaborate error handling which complicates locking
3. A workaround for autorepeat is included
> > This leaves me with a planning difficulty. For keyboards it is not fully
> > transparent. The LEDs are switched off when then keyboard is suspended.
> > Should I now implement a mode where active LEDs block suspension and if
> > so, how do I switch it on?
>
> Maybe module parameter of usbhid could be used to specify the desired
> behavior?
Yes, but what are the desired behaviors?
Regards
Oliver
next prev parent reply other threads:[~2007-10-06 9:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-10-05 11:29 even newer version of USB HID autosuspend Oliver Neukum
2007-10-05 16:36 ` Jiri Kosina
2007-10-06 9:15 ` Oliver Neukum [this message]
2007-10-07 18:57 ` Dmitry Torokhov
2007-10-07 20:58 ` Jiri Kosina
2007-10-08 7:02 ` Oliver Neukum
2007-10-08 13:44 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200710061115.53986.oliver@neukum.org \
--to=oliver@neukum.org \
--cc=dmitry.torokhov@gmail.com \
--cc=jikos@jikos.cz \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-usb-devel@lists.sourceforge.net \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).