* [2.6 patch] input/serio/hp_sdc.c section fix
@ 2007-10-24 16:26 Adrian Bunk
2007-10-28 5:03 ` Dmitry Torokhov
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2007-10-24 16:26 UTC (permalink / raw)
To: dmitry.torokhov; +Cc: linux-input, linux-kernel
hp_sdc_exit() mustn't be __exit since it's called from the
__init hp_sdc_register().
This patch fixes the following section mismatch:
<-- snip -->
...
MODPOST vmlinux.o
...
WARNING: vmlinux.o(.init.text+0x1af68): Section mismatch: reference to .exit.text:hp_sdc_exit (between 'hp_sdc_register' and 'hp_sdc_mlc_init')
...
<-- snip -->
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
4022ed345d1b61dc5b6ac0fc35877656e444a11d
diff --git a/drivers/input/serio/hp_sdc.c b/drivers/input/serio/hp_sdc.c
index 6af1998..02b3ad8 100644
--- a/drivers/input/serio/hp_sdc.c
+++ b/drivers/input/serio/hp_sdc.c
@@ -944,11 +944,7 @@ static int __init hp_sdc_init_hppa(struct parisc_device *d)
#endif /* __hppa__ */
-#if !defined(__mc68000__) /* Link error on m68k! */
-static void __exit hp_sdc_exit(void)
-#else
static void hp_sdc_exit(void)
-#endif
{
write_lock_irq(&hp_sdc.lock);
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [2.6 patch] input/serio/hp_sdc.c section fix
2007-10-24 16:26 [2.6 patch] input/serio/hp_sdc.c section fix Adrian Bunk
@ 2007-10-28 5:03 ` Dmitry Torokhov
0 siblings, 0 replies; 2+ messages in thread
From: Dmitry Torokhov @ 2007-10-28 5:03 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-input, linux-kernel
On Wednesday 24 October 2007 12:26, Adrian Bunk wrote:
> hp_sdc_exit() mustn't be __exit since it's called from the
> __init hp_sdc_register().
>
Applied, thank you Adrian.
--
Dmitry
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-10-28 5:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-10-24 16:26 [2.6 patch] input/serio/hp_sdc.c section fix Adrian Bunk
2007-10-28 5:03 ` Dmitry Torokhov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).