[PATCH] input - Add Euro and Dollar keys

[PATCH] input - Add Euro and Dollar keys

[Carlos Corbacho]

From: Carlos Corbacho <cathectic@gmail.com>

Most newer Acer laptops (from 2005 onwards) now ship with an extra Dollar
and Euro key either side of the 'Up' arrow. These cannot be mapped in the 
traditional way, since they are not combination keys.

Signed-off-by: Carlos Corbacho <cathectic@gmail.com>
---
Dimitry,

1) This patch is based against Linus' tree, since your 
include/linux/input.h is out of date.

2) I am aware that there was some discussion over whether KEY_EURO should
become KEY_CURRENCY, due to concerns that Acer may one day release a laptop
with a different currency key instead of the Euro.

If you would prefer this patch to be redone with KEY_CURRENCY instead, then
I am happy to do so, if it means this will go upstream.

diff --git a/include/linux/input.h b/include/linux/input.h
index 6226892..b45f240 100644
--- a/include/linux/input.h
+++ b/include/linux/input.h
@@ -527,6 +527,9 @@ struct input_absinfo {
 #define KEY_SPELLCHECK		0x1b0   /* AL Spell Check */
 #define KEY_LOGOFF		0x1b1   /* AL Logoff */
 
+#define KEY_DOLLAR		0x1b2
+#define KEY_EURO		0x1b3
+
 #define KEY_DEL_EOL		0x1c0
 #define KEY_DEL_EOS		0x1c1
 #define KEY_INS_LINE		0x1c2

Re: [PATCH] input - Add Euro and Dollar keys

[Dmitry Torokhov]

On Thursday 25 October 2007, Carlos Corbacho wrote:
> From: Carlos Corbacho <cathectic@gmail.com>
> 
> Most newer Acer laptops (from 2005 onwards) now ship with an extra Dollar
> and Euro key either side of the 'Up' arrow. These cannot be mapped in the 
> traditional way, since they are not combination keys.

Applied, thank you Carlos. I tought about KEY_CURRENCY some more and I
don't think it would work well in this case.

-- 
Dmitry

Re: [PATCH] input - Add Euro and Dollar keys

[Carlos Corbacho]

Dmitry,

On Friday 26 October 2007 05:41:25 Dmitry Torokhov wrote:
> > Most newer Acer laptops (from 2005 onwards) now ship with an extra Dollar
> > and Euro key either side of the 'Up' arrow. These cannot be mapped in the
> > traditional way, since they are not combination keys.
>
> Applied, thank you Carlos. I tought about KEY_CURRENCY some more and I
> don't think it would work well in this case.

Unfortunately, my patch has a small problem, in that setkeycodes won't accept 
the values for my laptop keyboard (since they are obviously > 256).

Is there another way around this (besides submitting another patch to move the 
keys to lower keycodes - e.g. something in the 246-255 range)?

-Carlos
-- 
E-Mail: carlos@strangeworlds.co.uk
Web: strangeworlds.co.uk
GPG Key ID: 0x23EE722D