From: Stephen Hemminger <shemminger@linux-foundation.org>
To: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Cc: Pavel Machek <pavel@ucw.cz>, Len Brown <lenb@kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
linux-input@atrey.karlin.mff.cuni.cz,
linux-kernel@vger.kernel.org
Subject: [PATCH] Fujitsu application panel led value
Date: Wed, 12 Dec 2007 15:21:43 -0700 [thread overview]
Message-ID: <20071212152143.04c83e93@shemminger-laptop> (raw)
In-Reply-To: <d120d5000712120610m30c054f5w596c29a1700211f@mail.gmail.com>
Use proper encoding for LED values.
Signed-off-by: Stephen Hemminger <shemminger@linux-foundation.org>
---
Note: earlier code worked because hardware only checks for zero.
--- a/drivers/input/misc/apanel.c 2007-12-12 13:07:03.000000000 -0700
+++ b/drivers/input/misc/apanel.c 2007-12-12 14:42:09.000000000 -0700
@@ -132,11 +132,11 @@ static void mail_led_set(struct led_clas
enum led_brightness value)
{
struct apanel *ap = container_of(led, struct apanel, mail_led);
- if (value)
+
+ if (value != LED_OFF)
ap->led_bits |= 0x8000;
else
ap->led_bits &= ~0x8000;
- ap->led_bits = value;
schedule_work(&ap->led_work);
}
next prev parent reply other threads:[~2007-12-12 22:21 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-02 18:17 [PATCH] fujtisu application panel driver Stephen Hemminger
2007-07-02 19:16 ` Dmitry Torokhov
2007-09-03 8:58 ` Stephen Hemminger
2007-09-07 12:02 ` Pavel Machek
2007-09-12 11:38 ` [PATCH] Fujitsu application panel driver (rev3) Stephen Hemminger
2007-09-14 5:30 ` Dmitry Torokhov
2007-09-16 19:55 ` Stephen Hemminger
2007-09-16 20:22 ` Dmitry Torokhov
2007-10-23 19:55 ` [PATCH] Fujitsu application panel driver Stephen Hemminger
2007-10-24 23:03 ` Andrew Morton
2007-10-25 20:19 ` [PATCH] apanel: space savings Stephen Hemminger
2007-10-28 5:30 ` [PATCH] Fujitsu application panel driver Dmitry Torokhov
2007-11-18 22:36 ` Robert Gerlach
2007-11-19 4:43 ` Stephen Hemminger
2007-11-19 12:50 ` Robert Gerlach
2007-11-19 17:26 ` Stephen Hemminger
2007-11-19 20:37 ` Robert Gerlach
2007-11-19 23:19 ` Stephen Hemminger
2007-12-19 9:04 ` Robert Gerlach
2007-12-12 14:10 ` Dmitry Torokhov
2007-12-12 22:21 ` Stephen Hemminger [this message]
2007-07-05 1:29 ` [PATCH] fujtisu " Jason Uhlenkott
2007-09-03 9:00 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071212152143.04c83e93@shemminger-laptop \
--to=shemminger@linux-foundation.org \
--cc=akpm@linux-foundation.org \
--cc=dmitry.torokhov@gmail.com \
--cc=lenb@kernel.org \
--cc=linux-input@atrey.karlin.mff.cuni.cz \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox